Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: rn modal.prompt, ref #1011 #1089

Merged
merged 2 commits into from
Apr 7, 2017
Merged

feature: rn modal.prompt, ref #1011 #1089

merged 2 commits into from
Apr 7, 2017

Conversation

silentcloud
Copy link
Contributor

rn modal prompt

@mention-bot
Copy link

@silentcloud, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lixiaoyang1992, @yiminghe and @warmhug to be potential reviewers.

@codecov
Copy link

codecov bot commented Mar 31, 2017

Codecov Report

Merging #1089 into master will decrease coverage by 2.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
- Coverage   70.42%   67.47%   -2.95%     
==========================================
  Files         215      118      -97     
  Lines        3983     1977    -2006     
  Branches     1190      559     -631     
==========================================
- Hits         2805     1334    -1471     
+ Misses       1177      642     -535     
  Partials        1        1
Flag Coverage Δ
#rn ?
#web 67.47% <ø> (ø) ⬆️
Impacted Files Coverage Δ
components/refresh-control/index.tsx
components/date-picker/index.tsx
components/picker/styles.tsx
components/list-view/index.tsx
components/card/CardFooter.tsx
components/card/CardBody.tsx
components/tab-bar/tabbar.ios.tsx
components/drawer/index.tsx
components/action-sheet/index.tsx
components/steps/StepsItem.tsx
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e6f647...2b701eb. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 31, 2017

Codecov Report

Merging #1089 into master will decrease coverage by 0.61%.
The diff coverage is 37.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
- Coverage   70.42%   69.81%   -0.62%     
==========================================
  Files         215      218       +3     
  Lines        3983     4058      +75     
  Branches     1190     1213      +23     
==========================================
+ Hits         2805     2833      +28     
- Misses       1177     1224      +47     
  Partials        1        1
Flag Coverage Δ
#rn 72.03% <37.66%> (-1.3%) ⬇️
#web 67.47% <ø> (ø) ⬆️
Impacted Files Coverage Δ
components/modal/style/prompt.tsx 100% <100%> (ø)
components/modal/index.tsx 100% <100%> (+12.5%) ⬆️
components/modal/PromptContainer.tsx 31.66% <31.66%> (ø)
components/modal/prompt.tsx 50% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e6f647...2b701eb. Read the comment docs.

@paranoidjk paranoidjk merged commit 8c9ae4f into master Apr 7, 2017
@paranoidjk paranoidjk deleted the rn-modal-prompt branch April 7, 2017 05:16
@silentcloud silentcloud mentioned this pull request Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants