fix flex #1532 #1549
Merged
fix flex #1532 #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pingan1927, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yiminghe and @paranoidjk to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## feature-2.0 #1549 +/- ##
==============================================
+ Coverage 65.37% 66.1% +0.73%
==============================================
Files 120 226 +106
Lines 2166 2269 +103
Branches 607 696 +89
==============================================
+ Hits 1416 1500 +84
- Misses 749 768 +19
Partials 1 1
Continue to review full report at Codecov.
|
|
@pingan1927 两个问题，
|
|
@paranoidjk 你仔细看看lint内容，目前的几个lint报错都是其他组件引起的。且都不是代码层面的问题。 |
|
@pingan1927 rebase master, 我上周已经修复了。 |
paranoidjk
reviewed
Jul 11, 2017
CHANGELOG.en-US.md
Outdated
| @@ -30,6 +30,7 @@ timeline: true | |||
| to `input`(for web) or `TextInput`(for react native) element; | |||
| - Progress: `wrapStyle` has been replaced by `style` and `style` has been replaced by `barStyle` property. | |||
| - The `style` property now can custom style, eg: tintColor for switch | |||
| - `Flex` 清理冗余API. [#1532](https://github.com/ant-design/ant-design-mobile/issues/1532) | |||
There was a problem hiding this comment.
写明去掉了哪些 api。
changlog 存在的意义是用户升级的时候一个速查表，而不是还要他点进去看 issue，看代码。
附上 issue 只是给有需要的人，不是所有人。
paranoidjk
force-pushed
the
fix-flex-api
branch
2 times, most recently
from
ad1d753
to
03a5517
Compare
paranoidjk
force-pushed
the
fix-flex-api
branch
2 times, most recently
from
a3e40c8
to
bcf5f9c
Compare
|
close #1532 应该写在 PR 描述的开头。 review 的问题我帮你修复了。先合掉 |
lixiaoyang1992
pushed a commit
to lixiaoyang1992/ant-design-mobile
that referenced
this pull request
Apr 26, 2018
* feat: pagination current start from 1. close ant-design#1009 * refactor style for some components, ref ant-design#1380 * fix flex ant-design#1532 * update snap * modify CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1532
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
This change is