Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

重新整理和定义各组件的 style #1380

Closed
silentcloud opened this issue May 25, 2017 · 5 comments
Closed

重新整理和定义各组件的 style #1380

silentcloud opened this issue May 25, 2017 · 5 comments

Comments

@silentcloud
Copy link
Contributor

目前的组件基本都是把 style 定义在最外层的那个容器元素上,但实际上可能这个 style 定义在内层某些具体元素上才更有意义,比如: InputItem 的 style 定义在 input 元素上会更好,还有 TextareaItem 等等

@ant-design-bot
Copy link

It will be better to write your issue/comment in English, so more people can understand you.
And this means that more people can help you or benefit from your issue/comment.
See: ant-design/ant-design#4897

@silentcloud silentcloud added this to the 2.0.0 milestone May 25, 2017
@silentcloud silentcloud mentioned this issue May 25, 2017
33 tasks
@huyansheng3
Copy link

是的! 所以有什么比较好的办法解决这个问题吗?
ant-mobile rn 组件 增加 style 也只是给最外层容器加,估计只能拷贝份 styles,然后改需要的 styles 属性。

@paranoidjk
Copy link
Contributor

@huyansheng3 #1182

@silentcloud
Copy link
Contributor Author

@huyansheng3 只能这么干,后期改成纯对象了其实也是类似,只不过少了一次 stylesheet.flatten 而已

@benjycui
Copy link
Contributor

benjycui commented Jun 9, 2017

就从 web 组件的角度而言,styleclassName 应该是一一匹配才对?

e.g.

interface Component {
  style?: ...
  className?: ...
  subStyle?: ...
  subClassName?: ...
};

paranoidjk pushed a commit that referenced this issue Jul 13, 2017
* feat: pagination current start from 1. close #1009

* refactor style for some components, ref #1380

* fix flex #1532

* update snap

* modify CHANGELOG
@paranoidjk paranoidjk removed this from the 2.0.0 milestone Jul 14, 2017
silentcloud pushed a commit that referenced this issue Jul 18, 2017
* feat: pagination current start from 1. close #1009

* refactor style for some components, ref #1380

* fix flex #1532

* update snap

* modify CHANGELOG
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this issue Apr 26, 2018
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this issue Apr 26, 2018
* feat: pagination current start from 1. close ant-design#1009

* refactor style for some components, ref ant-design#1380

* fix flex ant-design#1532

* update snap

* modify CHANGELOG
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants