Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-picker添加了对批量添加图片的支持,一次性把所有添加的图片都返回,只触发一次onChange #3115

Merged

Conversation

melchior-voidwolf
Copy link
Contributor

@melchior-voidwolf melchior-voidwolf commented Mar 10, 2019

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@melchior-voidwolf
Copy link
Contributor Author

ref:#2895

@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@44d1835). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3115   +/-   ##
=========================================
  Coverage          ?   60.26%           
=========================================
  Files             ?       92           
  Lines             ?     2265           
  Branches          ?      648           
=========================================
  Hits              ?     1365           
  Misses            ?      891           
  Partials          ?        9
Flag Coverage Δ
#web 60.26% <0%> (?)
Impacted Files Coverage Δ
components/image-picker/index.tsx 32.52% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d1835...bf7decd. Read the comment docs.

@ziluo
Copy link
Contributor

ziluo commented Mar 14, 2019

这里引入Promise后需要check下兼容性问题,项目是否需要额外配置或直接引入polyfill文件 @melchior-voidwolf

@ziluo ziluo self-assigned this Mar 14, 2019
@melchior-voidwolf
Copy link
Contributor Author

melchior-voidwolf commented Mar 14, 2019

这里引入Promise后需要check下兼容性问题,项目是否需要额外配置或直接引入polyfill文件 @melchior-voidwolf

antd-mobile 的官方文档中已经推荐引入 Promise 的 fallback 支持的情况下,处理 fallback 的事情是否还需要内部处理 ?

@ziluo
Copy link
Contributor

ziluo commented Mar 14, 2019

还是存在一定的向下兼容风险的,建议在组件文档里强调一下吧 @melchior-voidwolf

@ziluo
Copy link
Contributor

ziluo commented Mar 15, 2019

+1

@ziluo ziluo merged commit 9640cc1 into ant-design:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants