Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(carousel): use class syntax, remove react-timer-mixin #859

Merged
merged 1 commit into from
Feb 21, 2017
Merged

refactor(carousel): use class syntax, remove react-timer-mixin #859

merged 1 commit into from
Feb 21, 2017

Conversation

paranoidjk
Copy link
Contributor

@paranoidjk paranoidjk commented Feb 21, 2017 •
edited

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@paranoidjk paranoidjk force-pushed the refactor/use-class-syantax branch 2 times, most recently from 3111456 to b1178b1 Compare February 21, 2017 07:53
@paranoidjk paranoidjk changed the title refactor(carousel): use class syntax refactor(carousel): use class syntax, remove react-timer-mixin Feb 21, 2017
@paranoidjk paranoidjk merged commit be5d295 into master Feb 21, 2017
@paranoidjk paranoidjk deleted the refactor/use-class-syantax branch February 21, 2017 08:04
@paranoidjk paranoidjk mentioned this pull request Feb 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@paranoidjk