✂️ dependency: remove puppeteer in dependencies #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chenshuai2144
commented
Mar 25, 2020
•
chenshuai2144
commented
- 不需要默认安装 puppeteer
- 自动使用用户的 chrome，如果找不到会再安装 puppeteer
afc163
reviewed
Mar 25, 2020
afc163
reviewed
Mar 30, 2020
| const findChrome = require('carlo/lib/find_chrome'); | ||
|
|
||
| const getBrowser = async () => { | ||
| try { |
afc163
reviewed
Mar 30, 2020
| console.log('🧲 no find chrome'); | ||
| } | ||
|
|
||
| try { |
afc163
reviewed
Mar 30, 2020
| } | ||
|
|
||
| async teardown() { | ||
| const { page, browser } = this.global; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.