Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] website logo height overflow #722

Closed
thinkasany opened this issue Mar 27, 2024 · 4 comments · Fixed by #723
Closed

[Bug] website logo height overflow #722

thinkasany opened this issue Mar 27, 2024 · 4 comments · Fixed by #723
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@thinkasany
Copy link
Collaborator

What happens?

#700
左侧logo把容器撑高了
image

dumi-theme-antd-web3@0.3.13 中修复了这个bug，可以通过升级去解决

How To Reproduce

Context

  • Ant Design Web3 Version:
  • Node Version:
  • Platform:
@thinkasany thinkasany mentioned this issue Mar 27, 2024
Closed
@jeasonstudio jeasonstudio added the good first issue Good for newcomers label Mar 27, 2024
@thinkasany
Copy link
Collaborator Author

@eeezgame 小伙伴发现的问题，可以看看他有没有空处理，先挂起。

@thinkasany thinkasany added the help wanted Extra attention is needed label Mar 27, 2024
@github-actions GitHub Actions
Copy link

Hello @thinkasany. We totally like your proposal/feedback, welcome to send us a Pull Request for it. provide changelog/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @thinkasany，我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。提供改动所需相应的 changelog、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献。

@kiner-tang
Copy link
Member

我这边刚好需要改 dumi-theme-antd-web3，我来身边升一级一下吧

@thinkasany
Copy link
Collaborator Author

我这边刚好需要改 dumi-theme-antd-web3，我来身边升一级一下吧

要不要问一下他，原本设想尽量邀请新的小伙伴加入开源大家庭。

image

eeezgame added a commit to eeezgame/ant-design-web3 that referenced this issue Mar 27, 2024
@eeezgame
fix:website logo height overflow ant-design#722
bf87dcb
This was referenced Mar 27, 2024
Closed
Merged
eeezgame added a commit to eeezgame/ant-design-web3 that referenced this issue Mar 27, 2024
@eeezgame
fix:website logo height overflow ant-design#722
682c654
@kiner-tang kiner-tang mentioned this issue Mar 27, 2024
Merged
kiner-tang added a commit that referenced this issue Mar 27, 2024
@eeezgame @kiner-tang
fix:website logo height overflow #722 (#723)
19d0a2a 
* fix:website logo height overflow #722

* chore: recreate pnpm-lock.yaml

* chore: recreate pnpm-lock.yaml

---------

Co-authored-by: kiner-tang <1127031143@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@kiner-tang @jeasonstudio @thinkasany