Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:website logo height overflow #722 #723

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

eeezgame
Copy link
Contributor

[中文版模板 / Chinese template]

💡 Background and solution

左侧logo把容器撑高了

1711511012266

dumi-theme-antd-web3@0.3.13 中修复了这个bug,通过升级解决了此问题

🔗 Related issue link

fix #722

Copy link

changeset-bot bot commented Mar 27, 2024

⚠️ No Changeset found

Latest commit: 43ed009

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 8:36am

Copy link

github-actions bot commented Mar 27, 2024

Preview is ready

@thinkasany
Copy link
Collaborator

thinkasany commented Mar 27, 2024

奇怪,package.json 的文件不应该也有修改么 @eeezgame

@eeezgame
Copy link
Contributor Author

奇怪,package.json 的文件不应该也有修改么 @eeezgame

pnpm update dumi-theme-antd@0.3.13
我用这个命令更新了依赖

@kiner-tang
Copy link
Member

image 并没有解决这个问题

@kiner-tang
Copy link
Member

umi-theme-antd-web3@0.3.13 应该要升级这个库吧

@eeezgame
Copy link
Contributor Author

eeezgame commented Mar 27, 2024

umi-theme-antd-web3@0.3.13 应该要升级这个库吧

是的 更新错包了 应该更新 dumi-theme-antd-web3

@kiner-tang
Copy link
Member

image 看起来正常了

@kiner-tang
Copy link
Member

不过 ci 怎么还 挂了呢,我瞅瞅

@eeezgame
Copy link
Contributor Author

跟我git操作有关系吗 我是git reset HEAD~ 后更新依赖 强制推送分支

@kiner-tang
Copy link
Member

跟我git操作有关系吗 我是git reset HEAD~ 后更新依赖 强制推送分支

可能跟 pnpm-lock.yml 有关,我重新生成试试

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (74102b1) to head (43ed009).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #723   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          651       651           
  Lines        17771     17771           
  Branches      1113      1113           
=========================================
  Hits         17771     17771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang kiner-tang merged commit 19d0a2a into ant-design:main Mar 27, 2024
9 checks passed
Copy link

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us.

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们。

Ant Design Web3 Community Group QCcode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] website logo height overflow
3 participants