Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typos #644

Merged
merged 1 commit into from
Mar 15, 2024
Merged

docs: fix typos #644

merged 1 commit into from
Mar 15, 2024

Conversation

thinkasany
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Mar 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 7:10am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2024

⚠️ No Changeset found

Latest commit: bd7de64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 15, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d273651) to head (bd7de64).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #644   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          650       650           
  Lines        17502     17502           
  Branches      1070      1070           
=========================================
  Hits         17502     17502

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kiner-tang
kiner-tang reviewed Mar 15, 2024
View reviewed changes
packages/web3/src/types/index.md
@@ -85,7 +85,7 @@ This is an enum type that contains the IDs of some commonly used chains. Its val
| chain | Current chain | [Chain](#chain) | - | - |
| availableChains | List of available chains | [Chain](#chain)\[] | - | - |
| availableWallets | List of available wallets | [Wallet](#wallet)\[] | - | - |
| connect | Connect to the chain | `(wallet: Wallet, options?: ConnectOptions) => Promise<void>` | - | - |
| connect | Connect to the wallet | `(wallet: Wallet, options?: ConnectOptions) => Promise<void>` | - | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中文文档是不是也得改一下

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中文是对的。

5c58639

image

@thinkasany thinkasany merged commit 5383e19 into ant-design:main Mar 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiner-tang kiner-tang kiner-tang left review comments

@yutingzhao1991 yutingzhao1991 yutingzhao1991 approved these changes

@jeasonstudio jeasonstudio Awaiting requested review from jeasonstudio

@gin-lsl gin-lsl Awaiting requested review from gin-lsl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thinkasany @yutingzhao1991 @kiner-tang