Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependabot): update update-type for ethers #961

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

thinkasany
Copy link
Collaborator

[中文版模板 / Chinese template]

💡 Background and solution

🔗 Related issue link

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 2:17am

Copy link

changeset-bot bot commented Jun 12, 2024

⚠️ No Changeset found

Latest commit: dd99525

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

github-actions bot commented Jun 12, 2024

Prepare preview

@thinkasany thinkasany changed the title chore(dependabot):ignore ethers for examples/packages chore(dependabot): ignore ethers for examples/packages Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (61c17c5) to head (dd99525).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #961   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          712       712           
  Lines        21624     21629    +5     
  Branches      1225      1231    +6     
=========================================
+ Hits         21624     21629    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Jeason <me@cowpoke.cc>
@thinkasany
Copy link
Collaborator Author

参考 https://docs.github.com/zh/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#%E7%A4%BA%E4%BE%8B-3 示例三更改。

  1. 看了一下文档好像没找到不更新子包的方式,怀疑默认就是走了pnpm up --latest,要不然 pnpm add ethers@latest --workspace-root or pnpm add ethers@latest -w来手动更新根目录,然后那边就降低为minor,major的提示(减少提示频次),patch就不去动他了。到时候我来手动更新一下根目录。
  2. 之所以不直接ignore了是为了留着提示我们这个依赖已经更新了。

@thinkasany thinkasany marked this pull request as ready for review June 18, 2024 02:17
@thinkasany thinkasany changed the title chore(dependabot): ignore ethers for examples/packages chore(dependabot): update update-type for ethers Jun 18, 2024
@thinkasany
Copy link
Collaborator Author

ci has passed, please help me check it again. thx~ @jeasonstudio

Copy link
Collaborator

@jeasonstudio jeasonstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ♥️

@jeasonstudio jeasonstudio merged commit 5c82102 into main Jun 18, 2024
13 checks passed
@jeasonstudio jeasonstudio deleted the chore-ignore-ethers branch June 18, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants