Skip to content

Commit

Permalink
refactor: remove cascader displayRender warning (#35417)
Browse files Browse the repository at this point in the history
* refactor: remove useless warning (#35291)

* refactor: remove useless test case

* docs: remove cascader tagRender
  • Loading branch information
lalalazero committed May 10, 2022
1 parent f5831f1 commit 17cd13f
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 19 deletions.
11 changes: 0 additions & 11 deletions components/cascader/__tests__/index.test.js
Expand Up @@ -517,17 +517,6 @@ describe('Cascader', () => {
errorSpy.mockRestore();
});

it('displayRender & multiple', () => {
const errorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
mount(<Cascader multiple displayRender={() => null} />);

expect(errorSpy).toHaveBeenCalledWith(
'Warning: [antd: Cascader] `displayRender` not work on `multiple`. Please use `tagRender` instead.',
);

errorSpy.mockRestore();
});

it('should support showCheckedStrategy child', () => {
const multipleOptions = [
{
Expand Down
1 change: 0 additions & 1 deletion components/cascader/index.en-US.md
Expand Up @@ -49,7 +49,6 @@ Cascade selection box.
| status | Set validation status | 'error' \| 'warning' | - | 4.19.0 |
| style | The additional style | CSSProperties | - | |
| suffixIcon | The custom suffix icon | ReactNode | - | |
| tagRender | Customize tag render when `multiple` | (props) => ReactNode | - | 4.17.0 |
| value | The selected value | string\[] \| number\[] | - | |
| onChange | Callback when finishing cascader select | (value, selectedOptions) => void | - | |
| onDropdownVisibleChange | Callback when popup shown or hidden | (value) => void | - | 4.17.0 |
Expand Down
6 changes: 0 additions & 6 deletions components/cascader/index.tsx
Expand Up @@ -165,12 +165,6 @@ const Cascader = React.forwardRef((props: CascaderProps<any>, ref: React.Ref<Cas
'Cascader',
'`popupClassName` is deprecated. Please use `dropdownClassName` instead.',
);

devWarning(
!multiple || !props.displayRender,
'Cascader',
'`displayRender` not work on `multiple`. Please use `tagRender` instead.',
);
}

// =================== No Found ====================
Expand Down
1 change: 0 additions & 1 deletion components/cascader/index.zh-CN.md
Expand Up @@ -50,7 +50,6 @@ cover: https://gw.alipayobjects.com/zos/alicdn/UdS8y8xyZ/Cascader.svg
| status | 设置校验状态 | 'error' \| 'warning' | - | 4.19.0 |
| style | 自定义样式 | CSSProperties | - | |
| suffixIcon | 自定义的选择框后缀图标 | ReactNode | - | |
| tagRender | 自定义 tag 内容,多选时生效 | (props) => ReactNode | - | 4.17.0 |
| value | 指定选中项 | string\[] \| number\[] | - | |
| onChange | 选择完成后的回调 | (value, selectedOptions) => void | - | |
| onDropdownVisibleChange | 显示/隐藏浮层的回调 | (value) => void | - | 4.17.0 |
Expand Down

0 comments on commit 17cd13f

Please sign in to comment.