Skip to content

Commit

Permalink
chore(deps): bump actions/upload-artifact from 3 to 4 (#47287)
Browse files Browse the repository at this point in the history
* chore(deps): bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update preview-build.yml

Signed-off-by: lijianan <574980606@qq.com>

* Update test.yml

Signed-off-by: lijianan <574980606@qq.com>

* test: fix Unable to upload to same artifact name from multiple jobs

actions/upload-artifact#478 (comment)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: lijianan <574980606@qq.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: lijianan <574980606@qq.com>
Co-authored-by: afc163 <afc163@gmail.com>
  • Loading branch information
3 people committed Feb 2, 2024
1 parent b10f713 commit 1da53ec
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 13 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/preview-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
NODE_OPTIONS: "--max_old_space_size=4096"

- name: upload site artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: site
path: _site/
Expand All @@ -90,7 +90,7 @@ jobs:

- name: Upload PR number
if: ${{ always() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pr
path: ./pr-id.txt
Expand All @@ -116,7 +116,7 @@ jobs:
key: node_modules-${{ hashFiles('**/package-temp-dir/package-lock.json') }}

- name: download site artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: site
path: _site
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -207,16 +207,16 @@ jobs:
run: npm test -- --maxWorkers=2 --shard=${{matrix.shard}} --coverage

- name: persist coverages
if: ${{ matrix.module == 'dom' && matrix.react == '17' }}
if: ${{ matrix.module == 'dom' && matrix.react == '18' }}
run: |
mkdir persist-coverage
mv coverage/coverage-final.json persist-coverage/react-${{matrix.react}}-test-${{matrix.module}}-${{strategy.job-index}}.json
- uses: actions/upload-artifact@v3
if: ${{ matrix.module == 'dom' && matrix.react == '17' }}
- uses: actions/upload-artifact@v4
if: ${{ matrix.module == 'dom' && matrix.react == '18' }}
name: upload coverages
with:
name: coverage-artifacts
name: coverage-artifacts-${{ matrix.module }}-${{ matrix.react }}-${{ strategy.job-index }}
path: persist-coverage/

# node test
Expand Down Expand Up @@ -251,9 +251,10 @@ jobs:
with:
node-version: 18

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: coverage-artifacts
pattern: coverage-artifacts-*
merge-multiple: true
path: persist-coverage
- name: Merge Code Coverage
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/visual-regression-diff-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
# Upload report in `visualRegressionReport`
- name: upload report artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ always() }}
with:
name: visual-regression-report
Expand All @@ -109,7 +109,7 @@ jobs:

- name: Upload persist key
if: ${{ always() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: visual-regression-diff-ref
path: ./visual-regression-pr-id.txt
4 changes: 2 additions & 2 deletions .github/workflows/visual-regression-persist-start.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:

# Upload `imageSnapshots` on master
- name: upload report artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: image-snapshots
path: imageSnapshots.tar.gz
Expand All @@ -89,7 +89,7 @@ jobs:

- name: Upload persist key
if: ${{ always() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: visual-regression-ref
path: ./visual-regression-ref.txt

0 comments on commit 1da53ec

Please sign in to comment.