Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for Table props "expandIconAsCell" and "expandIconColumnIndex" #10819

Closed
1 task
kafkahw opened this issue Jun 6, 2018 · 14 comments
Closed
1 task
Labels
good first issue help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@kafkahw
Copy link

kafkahw commented Jun 6, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Props "expandIconAsCell" and "expandIconColumnIndex" are recommended to use for Table component in this issue (#3055). However, there's no docs about those two props.

What does the proposed API look like?

"expandIconAsCell" and "expandIconColumnIndex" show up in https://ant.design/components/table/

@afc163
Copy link
Member

afc163 commented Jun 7, 2018

expandIconAsCell and expandIconColumnIndex is not good API naming for Table IMO, so it is not documented yet. Maybe we should add another property like showExpandIcon or hideExpandIcon for #3055

@yesmeck yesmeck added good first issue help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Jun 9, 2018
@kafkahw
Copy link
Author

kafkahw commented Jul 28, 2018

I like the idea of adding another property called hideExpandIcon. It should be false by default. If user wants to hide the expand icon, they can easily put it onto Table.

<Table
   hideExpandIcon
   {...otherProps}
/>

@IssueHuntBot
Copy link

@BoostIO funded this issue with $60. Visit this issue on Issuehunt

@hengkx
Copy link
Member

hengkx commented Aug 31, 2018

I think showExpandIcon is better. It value can be boolean and number. default true.
When the value is number type, less than 0 does not show icon, greater than or equal to 0 in the specified position show icon.

@hengkx
Copy link
Member

hengkx commented Aug 31, 2018

#11802
Can we deal with this issue together?

@IssueHuntBot
Copy link

@twisger has started working. Visit this issue on Issuehunt

@twisger
Copy link
Contributor

twisger commented Aug 31, 2018

@afc163
I think the api should looks like
expandIcons: { expand: <Icon type="plus" />, collapse: <Icon type="minus" /> }
when it is assigned to null, the expandIcon will hide.

@IssueHuntBot
Copy link

@twisger has stopped working. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@Veveue has started working. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@Veveue has started working. See it on IssueHunt

@IssueHuntBot
Copy link

@afc163 has stopped working. See it on IssueHunt

@IssueHuntBot
Copy link

@rakshitkumarcse has submitted a pull request. See it on IssueHunt

@mighty-phoenix
Copy link
Contributor

expandIconAsCell and expandIconColumnIndex is not good API naming for Table IMO, so it is not documented yet. Maybe we should add another property like showExpandIcon or hideExpandIcon for #3055

I believe the names are just fine. They portray what they suppose. I don't think you should change them.
What do you think @afc163 ?

@IssueHuntBot
Copy link

@BoostIO has cancelled funding for this issue.(Cancelled amount: $60.00) See it on IssueHunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants