Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10819: Added docs for "expandIconAsCell" and "expandIconColumnIndex" #13750

Closed
wants to merge 2 commits into from
Closed

Conversation

mighty-phoenix
Copy link
Contributor

@mighty-phoenix mighty-phoenix commented Dec 20, 2018

Fixes #10819 : Added docs for "expandIconAsCell" and "expandIconColumnIndex"
First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your pull request, thank you!

  • Make sure that you propose pull request to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a pull request to keep commit history clear.
  • Add some descriptions and refer relative issues for you pull request.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@netlify
Copy link

netlify bot commented Dec 20, 2018

Deploy preview for ant-design ready!

Built with commit 1e07f51

https://deploy-preview-13750--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #13750 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13750      +/-   ##
==========================================
+ Coverage   93.71%   93.72%   +0.01%     
==========================================
  Files         314      314              
  Lines        6633     6633              
  Branches     1734     1765      +31     
==========================================
+ Hits         6216     6217       +1     
+ Misses        406      405       -1     
  Partials       11       11
Impacted Files Coverage Δ
components/upload/UploadList.tsx 88.49% <0%> (-1.77%) ⬇️
components/_util/wave.tsx 87.87% <0%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7473f9b...1e07f51. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #13750 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13750      +/-   ##
==========================================
+ Coverage   93.71%   93.72%   +0.01%     
==========================================
  Files         314      314              
  Lines        6633     6633              
  Branches     1734     1765      +31     
==========================================
+ Hits         6216     6217       +1     
+ Misses        406      405       -1     
  Partials       11       11
Impacted Files Coverage Δ
components/upload/UploadList.tsx 88.49% <0%> (-1.77%) ⬇️
components/_util/wave.tsx 87.87% <0%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7473f9b...1e07f51. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #13750 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13750      +/-   ##
==========================================
+ Coverage   93.71%   93.72%   +0.01%     
==========================================
  Files         314      314              
  Lines        6633     6633              
  Branches     1734     1765      +31     
==========================================
+ Hits         6216     6217       +1     
+ Misses        406      405       -1     
  Partials       11       11
Impacted Files Coverage Δ
components/upload/UploadList.tsx 88.49% <0%> (-1.77%) ⬇️
components/_util/wave.tsx 87.87% <0%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7473f9b...1e07f51. Read the comment docs.

@@ -67,6 +67,8 @@ const columns = [{
| expandedRowKeys | 展开的行,控制属性 | string\[] | - |
| expandedRowRender | 额外的展开行 | Function(record, index, indent, expanded):ReactNode | - |
| expandIcon | 自定义展开图标,参考[示例](http://react-component.github.io/table/examples/expandIcon.html) | Function(props):ReactNode | - |
| expandIconAsCell | 是否将expandIcon呈现为单元格。 | boolean | `false` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否将 expandIcon 显示为单元格。

@@ -67,6 +67,8 @@ const columns = [{
| expandedRowKeys | 展开的行,控制属性 | string\[] | - |
| expandedRowRender | 额外的展开行 | Function(record, index, indent, expanded):ReactNode | - |
| expandIcon | 自定义展开图标,参考[示例](http://react-component.github.io/table/examples/expandIcon.html) | Function(props):ReactNode | - |
| expandIconAsCell | 是否将expandIcon呈现为单元格。 | boolean | `false` |
| expandIconColumnIndex | expandIcon的索引,表示expandIconAsCell为false时将插入哪一列。 | number | 0 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expandIcon 的索引,当 expandIconAsCellfalse 时,会在这个位置插入一列

@afc163
Copy link
Member

afc163 commented Dec 21, 2018

@afc163 afc163 closed this Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for Table props "expandIconAsCell" and "expandIconColumnIndex"
3 participants