Button icon prop

[afc163]

<Button>
  <Icon type="star" />START
</Button>

==>

<Button icon="star">START</Button>

[plandem]

I would like to have same for TabPane.

[hotoo]

I think Button > Icon[type] is good enough.

<Button>
  <Icon type="star" />                Star
</Button>

<Button>
  Next                <Icon type="right" />
</Button>

[plandem]

if you are going to add 'icon' prop to Button, then probably it will be also a good idea to add it to other components - e.g. tabs. But i'm fine with current way - less to learn, lower learning curve => more users.

[afc163]

Just for Button because I like it. 👽

[afc163]

You guys can still use nested Icon.

[plandem]

please add to Tabs, because right now i have to use callback to render titles with icons.

[afc163]

<TabPane tab=<span><Icon type="xx" />tab 2</span> key="2">
  second
</TabPane>

Why callback?

[plandem]

because it's ugly and much more worse than was with Button.
Button was:

<Button><Icon type="xx"/>title</Button>

Button now:

<Button icon="xx">title</Button>

Tab now:

<TabPane tab=<span><Icon type="xx" />title</span>>
  second
</TabPane>

Tab can be:

<TabPane tab="title" icon=""xx">
  second
</TabPane>

As i said - your addition about icon would be better for tabs, than for buttons.

[afc163]

Ok, I consider it. Maybe you can give me a PR~

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.