Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new version of the icon filled mode is ugly #12053

Closed
1 task done
Hughen opened this issue Sep 4, 2018 · 9 comments
Closed
1 task done

The new version of the icon filled mode is ugly #12053

Hughen opened this issue Sep 4, 2018 · 9 comments
Assignees

Comments

@Hughen
Copy link
Contributor

Hughen commented Sep 4, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Before 3.9, the size of the actual content area of the icon is larger than the current icon. The advantage of this is that under the small size icon application scene, such as 15x15, you can see at a glance what the icon wants to express, but from This was not the case at the beginning of 3.9, and it did not take into account the small size.
I said that I am very sad.

v3.9.1: https://codesandbox.io/s/8pl7vj0np2
v3.8.4: https://codesandbox.io/s/zqzo1prom3

What does the proposed API look like?

Icon actual content area size is larger

@yesmeck
Copy link
Member

yesmeck commented Sep 4, 2018

@JuelChiang

@Hughen
Copy link
Contributor Author

Hughen commented Sep 5, 2018

Has anyone followed up on this issue?
I think the 3.9 version of the icon changes, it is very unacceptable

@afc163
Copy link
Member

afc163 commented Sep 5, 2018

We should enlarge 3.9 icons as 3.8's for compatibility.

@Hughen
Copy link
Contributor Author

Hughen commented Sep 6, 2018

@afc163
Do you mean to increase the icon and be forward compatible?

@afc163
Copy link
Member

afc163 commented Sep 6, 2018

Just Try ot make icon size same as previous version.

@HeskeyBaozi
Copy link
Contributor

HeskeyBaozi commented Sep 6, 2018

We can use the viewBox to solve this problem.
modify the viewBox from 0 0 1024 1024 to 64 64 896 896.
896 = (1024 * 875) / 1000, where the 875/1000 is the current size ratio path box / svg box.
64 = (1024 - 896) / 2.

The result preview

image

we will fix it in 3.9.2

@Hughen
Copy link
Contributor Author

Hughen commented Sep 6, 2018

Modifying the viewBox will make the code very bloated, because in order to pass the viewBox property, either use a custom component or children, but no matter which method I choose, I need to import @ant-design/icons, which is not Is it equivalent to rebuilding a Icon component?

@HeskeyBaozi
Copy link
Contributor

@Hughen This change only impact the offical icons in @ant-design/icons

@HeskeyBaozi
Copy link
Contributor

#12114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants