Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update @ant-design/icons@4.0.0-alpha.13 #20427

Merged
merged 1 commit into from
Dec 25, 2019

Conversation

vagusX
Copy link
Member

@vagusX vagusX commented Dec 24, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (update @ant-design/icons@4.0.0-alpha.13)

🔗 Related issue link

💡 Background and solution

根据 https://github.com/ant-design/ant-design-icons/blob/91c5ff8d587a6ee8d197c8971c8e9fedd0c3ec04/packages/icons-svg/build/strategies.ts#L46 描述,需要对测试用例的 snap 进行更新,这一块的更新也是 icons 本身这 7 个图标的 breaking changes

📝 Changelog

Language Changelog
🇺🇸 English none
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Dec 24, 2019

Deploy preview for ant-design ready!

Built with commit f0d38cb

https://deploy-preview-20427--ant-design.netlify.com

@vagusX vagusX requested a review from afc163 December 24, 2019 15:03
@vagusX
Copy link
Member Author

vagusX commented Dec 24, 2019

ping @HeskeyBaozi 可以帮忙补充下breaking change的原因嘛

@vagusX vagusX requested a review from zombieJ December 24, 2019 15:03
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0d38cb:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #20427 into 4.0-prepare will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           4.0-prepare   #20427   +/-   ##
============================================
  Coverage        97.57%   97.57%           
============================================
  Files              295      295           
  Lines             6760     6760           
  Branches          1856     1825   -31     
============================================
  Hits              6596     6596           
  Misses             164      164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd98901...f0d38cb. Read the comment docs.

@vagusX
Copy link
Member Author

vagusX commented Dec 24, 2019

v3 caret-up
image

v4 caret-up
image

@HeskeyBaozi
Copy link
Contributor

HeskeyBaozi commented Dec 24, 2019

be88393df5358c4e7c40bf2a4b321905
主要影响树形控件和表格表头排序。这些图标都是 3.9 以前的旧图标。现在调整至和其他图标一致的path box / svg box 比率,即viewBox修正为64 64 896 896,使得这些旧图标与其他已经在线上广泛使用的图标保持一致。现在这些实心箭头等图标会比原来稍显变大。

为什么是 64 64 896 896? 相关issue

@afc163
Copy link
Member

afc163 commented Dec 25, 2019

主要影响树形控件和表格表头排序

那这些地方的 fontSize 要相应调整一下,使其保持改动之前的显示大小。

@zombieJ
Copy link
Member

zombieJ commented Dec 25, 2019

@ant-design/icons@4.0.0-alpha.13 已经对 4.0-prepare snapshot 产生影响了。先合了。再开个 PR 来修一下部分图标的大小。 @vagusX

@zombieJ zombieJ merged commit 46e1ad1 into 4.0-prepare Dec 25, 2019
@zombieJ zombieJ deleted the feat/update-icons-version branch December 25, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants