Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button 增加 danger type #1308

Closed
mongris opened this issue Mar 31, 2016 · 5 comments
Closed

Button 增加 danger type #1308

mongris opened this issue Mar 31, 2016 · 5 comments
Labels
💄 Design It is a UI design issue

Comments

@mongris
Copy link

mongris commented Mar 31, 2016

除了目前支持的 types 外，往往在 UI 上还需要区分出比较危险的按钮，比如 “删除”

5e061768-669a-4059-8d3d-88bcc6f1ad61

在我们的项目中，我复制了 antd styles，对 button 的样式做了这方面的扩展（增加了 danger, success 类型）。但是在最新的 antd 中，type prop 做了限定。虽然运行不会有什么问题，但还是会输出大量的 warning。

不知道对这个建议是否会采纳，如果需要的话，可以 PR。
@afc163 afc163 closed this as completed in 5c884a6 Mar 31, 2016
@afc163
Copy link
Member

afc163 commented Mar 31, 2016

type 目前是按照 Ant Design 的设计规范来配置的，应该不会支持 danger success 这些按钮。

我这里去掉 type 的限制提示，方便上层业务扩展。

@afc163 afc163 added the 💄 Design It is a UI design issue label Mar 31, 2016
@afc163 afc163 mentioned this issue Jul 22, 2016
Closed
@afc163 afc163 reopened this Jan 10, 2017
@afc163
Copy link
Member

afc163 commented Jan 13, 2017

已经提交设计师讨论。

@afc163 afc163 mentioned this issue Jan 22, 2017
Merged
2 tasks
afc163 added a commit that referenced this issue Jan 23, 2017
@afc163
Add danger button
b30ae11 
close #1308
RaoHai pushed a commit that referenced this issue Jan 23, 2017
@afc163 @RaoHai
More types of Button (#4679)
f850993 
* Add Button[ghost] property, close #4625

* Add danger button

close #1308

* update API doc about ghost and danger property
@afc163 afc163 closed this as completed Jan 26, 2017
@afc163
Copy link
Member

afc163 commented Feb 26, 2017

@mongris 2.6 里已新增。

@mongris
Copy link
Author

mongris commented Feb 27, 2017

Thank you!

@lock
Copy link

lock bot commented May 2, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💄 Design It is a UI design issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mongris @afc163