Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix off-by-one error in loop #13573

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Conversation

s0
Copy link
Contributor

@s0 s0 commented Dec 11, 2018

This isn't a normal feature/bugfix PR, and I'm unsure if this is the sort of contribution you'd like to receive, but thought there's no harm in trying :)

This PR fixes an alert I found on LGTM.com, and there are a bunch of other alerts still remaining for this project that would probably also be good to fix (in particular the Potentially unsafe external links).

(Full disclosure: I'm part of the team behind LGTM.com)

cc @afc163

This fixes an alert that was found on LGTM.com
@afc163
Copy link
Member

afc163 commented Dec 11, 2018

This pull request fixes 1 alert when merging 907baa6 into d554fa8 - view on LGTM.com

fixed alerts:

  • 1 for Off-by-one comparison against length

Comment posted by LGTM.com

@netlify
Copy link

netlify bot commented Dec 11, 2018

Deploy preview for ant-design ready!

Built with commit 907baa6

https://deploy-preview-13573--ant-design.netlify.com

@afc163 afc163 merged commit 843056e into ant-design:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants