Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken submenu hover animation in vertical mode #13597

Closed
1 task done
eugene-rn opened this issue Dec 12, 2018 · 4 comments · Fixed by #13602
Closed
1 task done

Broken submenu hover animation in vertical mode #13597

eugene-rn opened this issue Dec 12, 2018 · 4 comments · Fixed by #13602

Comments

@eugene-rn
Copy link

eugene-rn commented Dec 12, 2018

Issuehunt badges

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.11.2

Environment

MacOS 10.14.1, Chrome 70

Reproduction link

Edit on CodeSandbox

Steps to reproduce

You just need to hover on the links with sub links.

What is expected?

Animated showing of submenu

What is actually happening?

Submenu shown without any transitions


It's happen when I doesn't pass mode="vertical" to Menu component. Vertical mode set by default, but there is no animation on hover in this case


IssueHunt Summary

ztplz ztplz has been rewarded.

Backers (Total: $20.00)

Submitted pull Requests


Tips

@ztplz
Copy link
Contributor

ztplz commented Dec 12, 2018

Oops! default is missing here. https://github.com/ant-design/ant-design/blob/master/components/menu/index.tsx#L226
But I don't think set mode by default is a best choice. It may be better to set it as a required
property for users to choose mode by themselves. What is your opinion?

@ztplz ztplz assigned ztplz and unassigned yutingzhao1991 Dec 12, 2018
@eugene-rn
Copy link
Author

I think it will be right solution

@IssueHuntBot
Copy link

@issuehuntfest has funded $20.00 to this issue. See it on IssueHunt

Copy link

issuehunt-oss bot commented Aug 31, 2024

@afc163 has rewarded $14.00 to @ztplz. See it on IssueHunt

  • 💰 Total deposit: $20.00
  • 🎉 Repository reward(20%): $4.00
  • 🔧 Service fee(10%): $2.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants