Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

card mode tabs component style is broken when browser scale is not 100% #15297

Closed
1 task done
rinick opened this issue Mar 9, 2019 · 0 comments
Closed
1 task done

card mode tabs component style is broken when browser scale is not 100% #15297

rinick opened this issue Mar 9, 2019 · 0 comments
Assignees
@chenshuai2144

Comments

@rinick
Copy link
Contributor

rinick commented Mar 9, 2019 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://ant.design/components/tabs/

Steps to reproduce

scale the browser up to something that's not 100% and check the style of tab bar

What is expected?

the border line only shows in inactive tabs, active tab doesn't have border line

What is actually happening?

the active tab sometimes also shows border line. when using retina display, you might see a line with half thickness.

Environment Info
antd 3.15.0
React 16.7.0
System windows 10
Browser chrome 71

the problem is, the tab's height is not integer, it's 39.6px. using this to block a line at 40px does not always work
This was referenced Mar 9, 2019
Closed
Merged
@afc163 afc163 closed this as completed Mar 9, 2019
This was referenced Mar 17, 2019
Closed
Merged
afc163 pushed a commit that referenced this issue Mar 18, 2019
@rinick @afc163
another try of fixing tab style (#15458)
b1ec61a 
* another try of fixing tab style

* fix card mode tab bottom line animation

#15299
#15297
#15234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenshuai2144 chenshuai2144

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@afc163 @rinick @chenshuai2144