Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Typography> should offer default styles for <table> inside it #17125

Open
1 task done
Stephen2 opened this issue Jun 16, 2019 · 2 comments
Open
1 task done

<Typography> should offer default styles for <table> inside it #17125

Stephen2 opened this issue Jun 16, 2019 · 2 comments
Assignees
Labels
💡 Feature Request help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@Stephen2
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Pages of copy (e.g., legal pages) look beautiful, just by using <Typography> and standard markup inside, with no custom CSS required.

Except for <table> which doesn't get any styling at all and looks lame.

Using the <Table> react component is overkill when you just want a table with simple copy inside it, and may be the styling is a bit "too much" for a simple table and will look jarring against the beautiful copy.

What does the proposed API look like?

No API, just some extra LESS like:

.antd-typography table { border: 1px solid @typography-table-border-color; }
.antd-typography table th { font-weight: 700; }

^^^ Anyway I just made that CSS up, not real examples I recommend

@zombieJ
Copy link
Member

zombieJ commented Jun 17, 2019

Good point 👍

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Dec 28, 2020
@ant-design-bot
Copy link
Contributor

Hello @Stephen2. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @Stephen2,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Feature Request help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

No branches or pull requests

4 participants