Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input：当自定义后缀图标和清除图标同时存在时，显示错误 #17414

Closed
1 task done
ohhoney1 opened this issue Jul 2, 2019 · 6 comments · Fixed by #17508, #17684 or #18151
Closed
1 task done

Input：当自定义后缀图标和清除图标同时存在时，显示错误 #17414

ohhoney1 opened this issue Jul 2, 2019 · 6 comments · Fixed by #17508, #17684 or #18151
Assignees
@chenshuai2144
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@ohhoney1
Copy link
Contributor

ohhoney1 commented Jul 2, 2019 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. 已经自定义了后缀图标，且允许清除图标存在
  2. 输入；输入足够多的内容

What is expected?

  1. 当输入的内容超过一定宽度时，清除图标正常显示；
  2. 当后缀图标自定义了大小，例如为 20，清除图标居中

What is actually happening?

  1. 当输入的内容超过一定宽度时，清除图标覆盖到了文字上；
  2. 当后缀图标自定义了大小，例如为 20，清除图标不居中
Environment Info
antd 3.20.0
React 16.8
System mac OS 10.14
Browser Chrome
@afc163 afc163 added the 🐛 Bug Ant Design Team had proved that this is a bug. label Jul 6, 2019
@ghost ghost mentioned this issue Jul 7, 2019
Merged
14 tasks
afc163 added a commit that referenced this issue Jul 8, 2019
@afc163
Merge pull request #17508 from LilyWakana/issue17414
2023e86 
fix: optimize Input presuffix style(#17414)
@yoyo837
Copy link
Contributor

yoyo837 commented Jul 15, 2019 •
edited
Loading

@LilyWakana

Chrome form autofill:

image

@yoyo837
Copy link
Contributor

yoyo837 commented Jul 15, 2019 •
edited
Loading

error state:

image

@brickspert
Copy link
Contributor

image

yesmeck added a commit that referenced this issue Jul 15, 2019
@yesmeck
Revert "fix: optimize Input presuffix style(#17414)"
61e0db5 
This reverts commit 9691d2b.
zombieJ pushed a commit that referenced this issue Jul 15, 2019
@yesmeck @zombieJ
Revert #17508 (#17639)
5b7c922 
* Revert "fix: Style property orders"

This reverts commit 54a992c.

* Revert "fix: optimize Input presuffix style(#17414)"

This reverts commit 9691d2b.
@ohhoney1
Copy link
Contributor Author

之前有注意到那个PR，没想到已经合了而且发布了。。 🤣建议发布个紧急版本吧

@yesmeck
Copy link
Member

yesmeck commented Jul 15, 2019

已发布 3.20.3

@yoyo837
Copy link
Contributor

yoyo837 commented Jul 15, 2019

这个issue reopen 吧

@yesmeck yesmeck reopened this Jul 15, 2019
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Jul 16, 2019
@ghost ghost mentioned this issue Jul 16, 2019
Merged
14 tasks
zombieJ pushed a commit that referenced this issue Jul 31, 2019
@zombieJ
fix: optimize Input presuffix style(#17414) (#17684)
f1fac6e
polina-shreyner pushed a commit to wowworks-team/wow-ant-design that referenced this issue Jul 31, 2019
@zombieJ
fix: optimize Input presuffix style(ant-design#17414) (ant-design#17684)
9c0dbe2
polina-shreyner pushed a commit to wowworks-team/wow-ant-design that referenced this issue Jul 31, 2019
@zombieJ
fix: optimize Input presuffix style(ant-design#17414) (ant-design#17684)
20f19df
@afc163 afc163 reopened this Aug 7, 2019
@afc163 afc163 mentioned this issue Aug 7, 2019
Closed
1 task
afc163 added a commit that referenced this issue Aug 7, 2019
@afc163
🐛 Fix Input clear icon align problem
57e05c5 
close #18150
close #17414
@afc163 afc163 mentioned this issue Aug 7, 2019
Merged
16 tasks
zombieJ pushed a commit that referenced this issue Aug 8, 2019
@afc163 @zombieJ
fix: Input clear icon align problem (#18151)
2cadd5b 
* 🐛 Fix Input clear icon align problem

close #18150
close #17414

* Update index.less
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenshuai2144 chenshuai2144

Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Milestone
No milestone
6 participants
@yesmeck @afc163 @yoyo837 @chenshuai2144 @brickspert @ohhoney1