Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript definition of CascaderOptionType missing some fields #17555

Closed
1 task done
ollierob opened this issue Jul 9, 2019 · 0 comments
Closed
1 task done

Typescript definition of CascaderOptionType missing some fields #17555

ollierob opened this issue Jul 9, 2019 · 0 comments
Assignees
@afc163
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@ollierob
Copy link

ollierob commented Jul 9, 2019 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

isLeaf and loading are presented as parts of the API in https://ant.design/components/cascader/#components-cascader-demo-lazy but are not included in the Typescript definitions of CascaderOptionType.

What does the proposed API look like?

The missing fields should be added.
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Jul 10, 2019
MrHeer added a commit to MrHeer/ant-design that referenced this issue Jul 11, 2019
@MrHeer
Fix: Typescript definition of CascaderOptionType missing some fields a…
7e4e5a8 
…nt-design#17555
@MrHeer MrHeer mentioned this issue Jul 11, 2019
Merged
14 tasks
@afc163 afc163 closed this as completed Jul 11, 2019
afc163 added a commit that referenced this issue Jul 11, 2019
@afc163
Merge pull request #17581 from MrHeer/fix-#17555
79bff3f 
fix: Typescript definition of CascaderOptionType missing some fields #17555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afc163 afc163

Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afc163 @ollierob