Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangePicker Bug #17878

Closed
1 task
ZackRong opened this issue Jul 25, 2019 · 5 comments · Fixed by #17983
Closed
1 task

RangePicker Bug #17878

ZackRong opened this issue Jul 25, 2019 · 5 comments · Fixed by #17983
Assignees
@afc163
Labels
🐛 Bug Ant Design Team had proved that this is a bug. 👷🏻‍♂️ Someone working on it

Comments

@ZackRong
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://ant.design/components/date-picker-cn/#components-date-picker-demo-presetted-ranges

Steps to reproduce

点击打开日期范围组件

What is expected?

此时，由于组件已经默认选择当前日期，点击选择另一日期，‘确定’按钮需要被激活

What is actually happening?

‘确定’按钮未被激活，需要再次点击默认选择的日期

Environment Info
antd 3.20.6
React 任意版本
System Mac
Browser Google
@xrkffgg
Copy link
Member

xrkffgg commented Jul 25, 2019

@rongzhx123 我想这个默认显示的 当前日期，并不是表示选中状态，而是一个 提示 当前日期的意思吧。

@ZackRong
Copy link
Author

@rongzhx123 我想这个默认显示的 当前日期，并不是表示选中状态，而是一个 提示 当前日期的意思吧。

但默认显示跟选中是同一状态，很容易误解

@afc163
Copy link
Member

afc163 commented Jul 29, 2019

图片

这个激活样式有点问题。@zombieJ

RangePicker 的当前日期样式之前和 DatePicker 不一致（或是没有？）应该是合理的。

图片

@afc163 afc163 added the 🐛 Bug Ant Design Team had proved that this is a bug. label Jul 29, 2019
@afc163
Copy link
Member

afc163 commented Jul 29, 2019 •
edited

相关 issue：react-component/calendar#557 (comment)

#13567

@afc163
Copy link
Member

afc163 commented Jul 29, 2019

还有这个：#16872

可以换一个样式或者像 2.x 一样去掉当前选项。

@afc163 afc163 mentioned this issue Jul 29, 2019
Closed
1 task
afc163 added a commit that referenced this issue Jul 30, 2019
@afc163
💄 optimize RangePicker active cell style
da741ec 
close #17878
close #13567
close #16872
@afc163 afc163 mentioned this issue Jul 30, 2019
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afc163 afc163

Labels
🐛 Bug Ant Design Team had proved that this is a bug. 👷🏻‍♂️ Someone working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style: optimize RangePicker active cell style ant-design/ant-design
3 participants
@afc163 @ZackRong @xrkffgg