Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload 照片墙动画令人难过 #22386

Closed
1 task done
BugHiding opened this issue Mar 19, 2020 · 3 comments · Fixed by #26367
Closed
1 task done

Upload 照片墙动画令人难过 #22386

BugHiding opened this issue Mar 19, 2020 · 3 comments · Fixed by #26367
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@BugHiding
Copy link
Contributor

BugHiding commented Mar 19, 2020 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. 一直上传图片到文件数量限制。
  2. 此时上传组件消失。（上传组件没有出现移动位置的消失动画。）
  3. 删除一张已上传图片。
  4. 上传组件出现的时候带有动画。(此时上传组件出现了移动位置的进场动画。)

What is expected?

希望消失的上传组件直接从删除的上传图片处出现，不需要进场动画。

What is actually happening?

上传组件有进场动画。

1

我的业务里面和 form 组件结合了，看起来就更奇怪了。

Environment Info
antd 4.0.3
React 16.12.0
System macOS 10.15.2
Browser Chrome 80.0.3987.132
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Mar 19, 2020
@ant-design-bot
Copy link
Contributor

Hello @BugHiding. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @BugHiding, 我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献！

giphy

@BugHiding
Copy link
Contributor Author

I will try.

@BugHiding
Copy link
Contributor Author

我看了源码实现，这个动画效果是通过图片卡片的动画来把上传组件挤开来的。实现非常的巧妙。暂时还没想到修改方法，我会继续想的。

@afc163 afc163 mentioned this issue Aug 24, 2020
Merged
19 tasks
afc163 added a commit that referenced this issue Aug 24, 2020
@afc163
style: tweak Upload list animation
c05ae84 
close #22386
afc163 added a commit that referenced this issue Aug 24, 2020
@afc163
style: 💄 fix Upload picture-card button style (#26367)
24a86df 
* style: fix Upload picture-card button style

close #26317
close #23339

* style: tweak Upload list animation

close #22386

* fix snapshot change

* docs: update Upload demos

* add test case

* update form demo

* fix test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style: 💄 fix Upload picture-card button style ant-design/ant-design
3 participants
@afc163 @BugHiding @ant-design-bot