Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are hardcoded values on less files #2424

Closed
mzamoras opened this issue Jul 19, 2016 · 4 comments
Closed

There are hardcoded values on less files #2424

mzamoras opened this issue Jul 19, 2016 · 4 comments

Comments

@mzamoras
Copy link

Sorry maybe I didn't follow the guidelines, but this issue has nothing to do with my system configuration and I'm sure no example is needed.

Using antd version 1.6.5.

Following the guide: https://github.com/ant-design/antd-init/tree/master/examples/customize-antd-theme to modify the theme style and color, some values are not reflected because the less files have hardcoded values instead of the variables it should be referenced to.

Little example:
In the style for radio: ( ant-design/components/radio/style/index.less )

.@{radio-prefix-cls}-button-wrapper {
  margin: 0;
  height: 28px;
  line-height: 26px;
  color: #666;  //  <== should be @text-color  or @btn-default-color
  display: inline-block;
  transition: all 0.3s ease;
  cursor: pointer;
  border: 1px solid @border-color-base;
  border-left: 0;
  background: #fff;  // <== should be @btn-default-bg or @body-background
  padding: 0 16px;

  a {
    color: #666; //  <== should be @text-color  or @btn-default-color
  }
}

I've found many of this hardcoded values, making very difficult to actually modify the style.

@afc163
Copy link
Member

afc163 commented Jul 19, 2016

PR is welcome~

@mzamoras
Copy link
Author

sure, thanks!

@afc163
Copy link
Member

afc163 commented Aug 10, 2016

@mzamoras ping~

@lock
Copy link

lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants