Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal close will roll up #26528

Closed
hengkx opened this issue Sep 2, 2020 · 9 comments · Fixed by #26538 or react-component/dialog#202
Closed

Modal close will roll up #26528

hengkx opened this issue Sep 2, 2020 · 9 comments · Fixed by #26538 or react-component/dialog#202
Labels
🐛 Bug Ant Design Team had proved that this is a bug. 👷🏻‍♂️ Someone working on it

Comments

@hengkx
Copy link
Member

hengkx commented Sep 2, 2020

#26507 (review)

@hengkx hengkx added the 🐛 Bug Ant Design Team had proved that this is a bug. label Sep 2, 2020
@afc163
Copy link
Member

afc163 commented Sep 2, 2020

这是 #26507 的问题还是 master 的问题?

@xrkffgg
Copy link
Member

xrkffgg commented Sep 2, 2020

@hengkx @jhoneybee

@jhoneybee
Copy link
Contributor

这是 #26507 的问题还是 master 的问题?

这个是 feature 分支上 commit 的 fdc36b6的问题。

以下情况下可以复现

  1. 从主仓库下载源码
#  commit hash fdc36b6
git clone https://github.com/ant-design/ant-design.git -b feature
  1. yarn && yarn start
  2. 在屏幕 保持尺寸 580px * 547px
  3. 点击 Open Modal with customized button props 这个按钮

master 的我正在测试,稍等以下

@afc163
Copy link
Member

afc163 commented Sep 2, 2020

https://ant.design 上有这个问题么?

@xrkffgg
Copy link
Member

xrkffgg commented Sep 2, 2020

Mac 我没测出来。。。 Windows 他们说是有问题。

@jhoneybee 来个 gif

@hengkx
Copy link
Member Author

hengkx commented Sep 2, 2020

https://ant.design 上有这个问题么?

有,我引用的 那个gif就是

@jhoneybee
Copy link
Contributor

jhoneybee commented Sep 2, 2020

antd

@afc163 @xrkffgg https://ant.design 也存在这个问题

@afc163
Copy link
Member

afc163 commented Sep 2, 2020

看上去和网站的横向滚动条有关系,本来就不应该有,我去掉好了。

@hengkx
Copy link
Member Author

hengkx commented Sep 2, 2020

我没有 横向 滚动 也这样

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Ant Design Team had proved that this is a bug. 👷🏻‍♂️ Someone working on it
Projects
None yet
4 participants