Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React router link to internal route causes page reload #26624

Closed
1 task done
EugeneSnihovsky opened this issue Sep 7, 2020 · 4 comments
Closed
1 task done

React router link to internal route causes page reload #26624

EugeneSnihovsky opened this issue Sep 7, 2020 · 4 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@EugeneSnihovsky
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://stackblitz.com/edit/react-o6kvyr?file=index.js

Steps to reproduce

Click on link in stackblitz example. Route will changed and whole page will reload

What is expected?

Navigation with react-router-dom to internal route should not lead to page reload

Environment Info
antd 4.6.3
React 16.13.1
System MacOS 10.15.6
Browser Chrome
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Sep 7, 2020
@ant-design-bot
Copy link
Contributor

Hello @EugeneSnihovsky. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @EugeneSnihovsky, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

@ghost
Copy link

ghost commented Sep 7, 2020

hello @EugeneSnihovsky how can I help with this?

@kiyutink
Copy link

Hey,
Could someone please provide some insight into why the PR has been closed? I'm considering picking this up but would need some info

@afc163
Copy link
Member

afc163 commented Jan 20, 2022

See #33770 (comment)

@afc163 afc163 closed this as completed Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants