Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key events on checkbox #27757

Closed
1 task
nicolasrhc opened this issue Nov 13, 2020 · 2 comments · Fixed by react-component/checkbox#204
Closed
1 task

Key events on checkbox #27757

nicolasrhc opened this issue Nov 13, 2020 · 2 comments · Fixed by react-component/checkbox#204
Labels
good first issue help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@nicolasrhc
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

You just have to call the checkbox component, click on it, and press a key

What is expected?

The onKeyDown and onKeyPress events are expected to be called when a key is pressed and the onKeyUp event to be called when the key is released

What is actually happening?

The onKeyDown and onKeyPress events are not called on keypress, and the onKeyUp event does not exist in the component, although it is in the native htm component

Environment Info
antd undefined
React react
System windows 10
Browser chrome
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Nov 13, 2020
@ant-design-bot
Copy link
Contributor

Hello @nicolasrhc. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @nicolasrhc, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

@BraisedChicken
Copy link

是 rc-checkbox 的问题吧,rc-checkbox的表现和这边是一致的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants