Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checkbox key events #204

Merged
merged 3 commits into from
Dec 8, 2020
Merged

add checkbox key events #204

merged 3 commits into from
Dec 8, 2020

Conversation

liuchao233
Copy link
Contributor

@liuchao233 liuchao233 commented Nov 17, 2020

添加 onKeyDown onKeyPress onKeyUp 事件,修复问题 #203 #27757

close #203
close ant-design/ant-design#27757

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #204 (e442191) into master (0767540) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #204   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           39        42    +3     
  Branches         6         6           
=========================================
+ Hits            39        42    +3     
Impacted Files Coverage Δ
src/index.jsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0767540...e442191. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Nov 18, 2020

Please add test case.

@afc163
Copy link
Member

afc163 commented Nov 18, 2020

image

这三行没覆盖。

@liuchao233
Copy link
Contributor Author

image

这三行没覆盖。

请问这种加默认值的代码应该怎么覆盖呢,测试和 demo 我都加上了。

@afc163
Copy link
Member

afc163 commented Nov 21, 2020

这三个是默认值,你需要不加 onKeyDown 属性,然后触发一下 keydown 才能跑到。

@afc163 afc163 merged commit 175ab8d into react-component:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG:Key events on checkbox Key events on checkbox
2 participants