-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drawer autoFocus #28097
Comments
Hello @gschattenhofer. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution! 你好 @gschattenhofer,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。 |
Is there anyone can help with reviewing the related PR🚀 in rc-drawer repsitory first? |
ant-design still using v4.3 but until v4.4.0 this is fixed in rc-drawer. |
4.17 is ready to be released, it will contain that fix. |
it might need some sync update in ant-design docs either? |
Hello, for who doesn't want to upgrade for the 4.17 alpha, can get the fix of the drawer here: Antd Version: 4.015 with the drawer auto focus LYALL <3 |
What problem does this feature solve?
When drawer opens, focusing on the element generates unexpected and/or unwanted UI behaviour. Specially if Drawer is positioned absolute in a specific container.
What does the proposed API look like?
Have a prop to disable autoFocus when drawer opens:
autoFocus={false}
The text was updated successfully, but these errors were encountered: