useMessage() should use getPopupContainer from <ConfigProvider /> #31841
Labels
help wanted
The suggestion or request has been accepted, we need you to help us by sending a pull request.
Comments
afc163
added
the
help wanted
|
Hello @tibdex. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution! 你好 @tibdex，我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献。
|
DaoxingHuang
added a commit
to DaoxingHuang/ant-design
that referenced
this issue
Aug 27, 2021
19 tasks
|
One PR has been raised . |
DaoxingHuang
added a commit
to DaoxingHuang/ant-design
that referenced
this issue
Sep 2, 2021
afc163
pushed a commit
that referenced
this issue
Sep 13, 2021
…>… (#31939) * fix:useMessage() should use getPopupContainer from <ConfigProvider /> #31841 * fix: useMessage() should use getPopupContainer from <ConfigProvider /> #31841 * add test case for useMessage hook * restore some changes * try to restore files agains * restore and keep the same as upstream master * restore files * restore some definition
Rain120
pushed a commit
to Rain120/ant-design
that referenced
this issue
Sep 14, 2021
…>… (ant-design#31939) * fix:useMessage() should use getPopupContainer from <ConfigProvider /> ant-design#31841 * fix: useMessage() should use getPopupContainer from <ConfigProvider /> ant-design#31841 * add test case for useMessage hook * restore some changes * try to restore files agains * restore and keep the same as upstream master * restore files * restore some definition
afc163
added a commit
that referenced
this issue
Sep 14, 2021
* feat: doc of week format in date-picker * feat: doc of week format in date-picker * fix: set the tree-switcher-leaf-line position (#32075) * fix(image): small size hide preview text (#29900) * fix(image): small size hide preview text * fix: image preview text ellipsis * fix: reset test * chore: improve icon search experience (#32098) * chore: improve icon search experience close #32097 * chore: search result empty data * feat: Georgian translation (#32106) * parent 18cd401 author Primlx <primulax@live.com> 1628778277 +0400 committer primulax <primulax@live.com> 1631181358 +0400 Add files via upload add georgian translation Create ka_GE.tsx Create ka_GE Rename ka_GE to ka_GE.tsx Create ka_GE.tsx Update ka_GE.tsx Update ka_GE.tsx Create ka_GE.tsx update rc-picker version Create ka_GE.tsx Create ka_GE Rename ka_GE to ka_GE.tsx Update ka_GE.tsx Update ka_GE.tsx Create ka_GE.tsx update rc-picker version * Update package.json Co-authored-by: Amumu <yoyo837@hotmail.com> * test case * add language option in markdown * test * Update components/calendar/locale/ka_GE.tsx Co-authored-by: Amumu <yoyo837@hotmail.com> * Update components/calendar/locale/ka_GE.tsx Co-authored-by: Amumu <yoyo837@hotmail.com> Co-authored-by: Amumu <yoyo837@hotmail.com> * docs: Update research-message-and-feedback.zh-CN.md (#32112) * fix: Use latest rc-picker version with defaultPickerValue/showTime fix (#32107) * update rc-picker dependency to 2.5.17 * add test: DatePicker.RangePicker with defaultPickerValue and showTime * fix: missing `default.css` (#32116) * chore: Add CI for compile * chore: Add missing compile file * docs: fix typo (#32121) * fix: preserve table pagination className (#32131) close #32130 * fix: use well typed PaginationLocale from rc-pagination (#32128) * docs: fix typo * fix: useMessage() should use getPopupContainer from <ConfigProvider />… (#31939) * fix:useMessage() should use getPopupContainer from <ConfigProvider /> #31841 * fix: useMessage() should use getPopupContainer from <ConfigProvider /> #31841 * add test case for useMessage hook * restore some changes * try to restore files agains * restore and keep the same as upstream master * restore files * restore some definition * feat: inherit rc-pagination props, more customizable (#32132) * feat: inherit rc-pagination props, more customizable close #32128, #32129 * chore: CustomSelect.Option is required by rc-pagination * fix: LocaleReceivier types issue * fix: lint issue, pageSize must be presented * chore: add Button.shape 'default' definition (#32004) * feat: add Button.shape 'default' * fix: ignore shape when falsy value * fix: generate className only when shape match * fix: remove necessary .ant-btn-default and update snapshot * fix: Cascader missing props (#32143) * fix: Cascader deps * docs: Update using new API * test: Test case cover * chore: compressed skip dup check * chore: remove redundant space after `should` (#32141) * chore(deps-dev): bump eslint-plugin-unicorn from 35.0.0 to 36.0.0 (#32149) Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) from 35.0.0 to 36.0.0. - [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases) - [Commits](sindresorhus/eslint-plugin-unicorn@v35.0.0...v36.0.0) --- updated-dependencies: - dependency-name: eslint-plugin-unicorn dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: fix modal demo in small screen * refactor(dropdown): add dropdownButtonType export and refactor defaultProps (#31957) Co-authored-by: btea <2356281422@qq.com> Co-authored-by: drizzlesconsin <69514654+drizzlesconsin@users.noreply.github.com> Co-authored-by: afc163 <afc163@gmail.com> Co-authored-by: Primlx <primulax@live.com> Co-authored-by: Amumu <yoyo837@hotmail.com> Co-authored-by: in_vane <52909860+in-vane@users.noreply.github.com> Co-authored-by: Thomas Zipner <thomas.zipner@gmail.com> Co-authored-by: 二货机器人 <smith3816@gmail.com> Co-authored-by: MD. Ariful Alam <swazan.arif@gmail.com> Co-authored-by: JounQin <admin@1stg.me> Co-authored-by: James <daoxingyue@live.cn> Co-authored-by: 绯一 <jaredleechn@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zuobin Wang <49583235+Dreamerryao@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduction link
Steps to reproduce
Everything is explained in the CodeSandbox.
What is expected?
As documented here, the goal of
useMessage()is to propagate the React contexts to the message.<ConfigProvider />'sgetPopupContainershould be one of the things propagated: using themessageApireturned byuseMessage()should mount messages in the popup container passed to<ConfigProvider />.What is actually happening?
getPopupContainerisn't picked up.Related to #5066 where it was possible to pass
getContainertomessageApiwithout having to rely on undesired global config (message.config()).The text was updated successfully, but these errors were encountered: