Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag 增加选中状态 #3560

Closed
ddcat1115 opened this issue Oct 24, 2016 · 11 comments · Fixed by #3671
Closed

Tag 增加选中状态 #3560

ddcat1115 opened this issue Oct 24, 2016 · 11 comments · Fixed by #3671
Assignees

Comments

@ddcat1115
Copy link
Contributor

  • 支持选中/取消,颜色需设计师指定
  • 增加相关demo
@ddcat1115
Copy link
Contributor Author

ddcat1115 commented Oct 28, 2016

视觉:

设计师的意见,觉得目前的状态色没有太大意义,建议下掉状态色功能,这样选中的蓝色不会跟原来的蓝色 Tag 冲突,大家看下这块有没有问题

@afc163
Copy link
Member

afc163 commented Oct 28, 2016

Ok

@benjycui
Copy link
Contributor

没选中没 hover 的标签没有背景色?

@ddcat1115
Copy link
Contributor Author

默认的标签样式不变,只是可选中的加hover和选中样式,同时去掉现有的状态色,图上无底色和边框的是设计师希望支持的特定场景,总结起来有这么几点:

  • 原有默认样式不变
  • 增加选中/取消功能,有hover和选中样式(如上图)
  • 去掉原有几种状态色
  • 支持无边框无底色样式的需求

@benjycui
Copy link
Contributor

增加选中/取消功能

增加 checked 属性。

有hover和选中样式(如上图)

所有 Tag 都有 hover、 checked 状态?还是只有 checkable 的才有 hover 状态?

去掉原有几种状态色

color 属性只能废弃,无法完全移除,要兼容。。

支持无边框无底色样式的需求

能给我个名字么。。都不知道怎么命名属性。。

@ddcat1115
Copy link
Contributor Author

  • 只有 checkable 的才有 hover 状态
  • 属性名字...... type: default | simple ?default 就是原来的样式,simple 就是无边框底色,但两者都checkable,checkable标签的 default 和 simple 的 hover和选中样式相同,这样ok不?

@afc163
Copy link
Member

afc163 commented Oct 31, 2016

color 属性不动就好,例子隐藏掉。

benjycui added a commit that referenced this issue Oct 31, 2016
benjycui added a commit that referenced this issue Nov 1, 2016
@benjycui
Copy link
Contributor

benjycui commented Nov 1, 2016

上下两排 Tag 之间的间隔最好也确认一下。

benjycui added a commit that referenced this issue Nov 1, 2016
benjycui added a commit that referenced this issue Nov 3, 2016
benjycui added a commit that referenced this issue Nov 3, 2016
benjycui added a commit that referenced this issue Nov 9, 2016
benjycui added a commit that referenced this issue Nov 9, 2016
benjycui added a commit that referenced this issue Nov 10, 2016
ddcat1115 added a commit that referenced this issue Nov 10, 2016
feat: make Tag checkable, close: #3560
@luojian001
Copy link

Tag关闭按钮不能用回调函数?

@benjycui
Copy link
Contributor

benjycui commented Nov 24, 2016

@lock
Copy link

lock bot commented May 3, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants