Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown.Button #3779

Closed
plandem opened this issue Nov 9, 2016 · 2 comments
Closed

Dropdown.Button #3779

plandem opened this issue Nov 9, 2016 · 2 comments
Assignees
@yesmeck

Comments

@plandem
Copy link
Contributor

plandem commented Nov 9, 2016

at documentation for Dropdown.Button we have:

  1. onVisibleChange
  2. visible

In reality these props are not using. So need to fix documentation or component.
@benjycui
Copy link
Contributor

This commit breaks it 0edd5ad

@yesmeck yesmeck self-assigned this Nov 10, 2016
@yesmeck yesmeck mentioned this issue Nov 10, 2016
Merged
yesmeck added a commit that referenced this issue Nov 10, 2016
@yesmeck
Pass visible and onVisibleChange to Dropdown, fix #3779
0b114bb
afc163 pushed a commit that referenced this issue Nov 11, 2016
@yesmeck @afc163
Pass visible and onVisibleChange to Dropdown, fix #3779 (#3782)
926425d
jljsj33 pushed a commit that referenced this issue Nov 11, 2016
@yesmeck @jljsj33
Pass visible and onVisibleChange to Dropdown, fix #3779 (#3782)
d78ea51
@plandem plandem mentioned this issue Nov 11, 2016
Closed
@lock
Copy link

lock bot commented May 3, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yesmeck yesmeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yesmeck @plandem @benjycui