Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timepicker使用hideDisabledOptions和disabledMinutes显示问题 #3793

Closed
cdoneshot opened this issue Nov 10, 2016 · 19 comments
Closed

timepicker使用hideDisabledOptions和disabledMinutes显示问题 #3793

cdoneshot opened this issue Nov 10, 2016 · 19 comments

Comments

@cdoneshot
Copy link

发生问题的环境是:

  • antd 版本:2.2.1
  • 操作系统及其版本:win10 x64
  • 浏览器及其版本:chrome 51

您做了什么?请提供尽可能详细的重现步骤。

timepicker配置disabledMinutes,disabledSeconds,同时禁止的0-59分,0-59秒,配置hideDisabledOptions=true。

您期待的结果是:

小时菜单占满整个弹层(或者其它比较美观的显示),而不是1/3。

实际上的结果是:

image

image

同时会报一个错,
Select.js?85f6:109 Uncaught TypeError: Cannot read property 'children' of null

在线演示:

https://codepen.io/cdoneshot/pen/WorvMY?editors=1010

@benjycui
Copy link
Contributor

...

你截图的是 DatePicker,却一直在说 TimePicker。

如果是 TimePicker 的话,请参考这个例子 https://ant.design/components/time-picker/#components-time-picker-demo-without-seconds

@benjycui
Copy link
Contributor

麻烦组织好语言,理清你的问题再开 issue,这种信息混乱的 issue 只是浪费彼此的时间。

@benjycui benjycui reopened this Nov 11, 2016
@cdoneshot
Copy link
Author

不好意思,我不明白我描述是不是有问题,但是datepicker在对时分秒的选择上配置同timepicker一样,所以我觉得是一个效果,后面给的链接是用timepicker重现的问题。

@benjycui
Copy link
Contributor

<DatePicker showTime={{ format: 'HH:mm' }} format="YYYY-MM-DD HH:mm" placeholder="Select Time" onChange={onChange} />

@cdoneshot
Copy link
Author

麻烦看一下重现的演示链接,不知道是我没有描述到点,还是你没有get到点。

ps:如果按照你给的配置,timepicker配置format:"HH:mm",可选的是时、分,如果配置为format:'HH',可选的依然是时、分,这里是不是也有一点问题

@afc163
Copy link
Member

afc163 commented Nov 11, 2016

样式上应该是撑满的。

@benjycui
Copy link
Contributor

在梳理相关的 demo,功能是正常的。

image

@benjycui
Copy link
Contributor

RangePicker 的有问题,之前 demo 没有覆盖到:

image

@afc163
Copy link
Member

afc163 commented Nov 11, 2016

image

楼主给的例子也很奇怪,除了面板里没撑满,弹出位置不对,弹出动画也不对。

@cdoneshot
Copy link
Author

上面的demo应该是用format配置的,我使用的是hideDisabledOption+disabledMinutes,这样子会报错

@afc163
Copy link
Member

afc163 commented Nov 11, 2016

你的例子也不太合适,如果使用 disabledMinutes disabledSeconds 禁止选择 0-59,那就是只展示小时面板。那你这么用就可以了:

<DatePicker showTime={{ format: 'HH' }} format="YYYY-MM-DD HH" />

disabledXxx 是用来禁选部分选项的。

@cdoneshot
Copy link
Author

你说的这种用法我也试过,这样配置依然面板依然可以选到分钟,我查看文档里面,format应该只支持到分钟。
image

@benjycui
Copy link
Contributor

benjycui commented Nov 11, 2016

文档已更新,途中发现两个问题:

下午我处理一下。

afc163 added a commit to react-component/time-picker that referenced this issue Nov 11, 2016
@afc163
Copy link
Member

afc163 commented Nov 11, 2016

  • 上面的提交修复了 Select.js?85f6:109 Uncaught TypeError: Cannot read property 'children' of null 的报错。

@afc163
Copy link
Member

afc163 commented Nov 11, 2016

  • 我在给 rc-time-picker 加一个 showMinute 属性,以支持 antd 中 <TimePicker format="HH" /><TimePicker format="ss" /> 的用法。

@afc163
Copy link
Member

afc163 commented Nov 11, 2016

TimePicker 本身的相关样式修正完毕,支持上面那条评论里的用法。

DatePicker 的内的 TimePicker 样式问题由 @benjycui 继续跟进。

@cdoneshot
Copy link
Author

DatePicker配置showToday={false}好像也没有作用= =

@benjycui
Copy link
Contributor

Done.

@lock
Copy link

lock bot commented May 3, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants