Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12 hour format for time picker #4063

Closed
andrewmclagan opened this issue Nov 30, 2016 · 9 comments
Closed

12 hour format for time picker #4063

andrewmclagan opened this issue Nov 30, 2016 · 9 comments
Labels
Accept You are right, we should do that help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@andrewmclagan
Copy link

(Apologies cannot read the issue template as its in Mandarin/Cantonese character set)

Would you be interested in a pull request for a 12 hour option on the time picker?
@benjycui benjycui added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Nov 30, 2016
@dreamcatcher081210
Copy link

+1，项目里同样遇到这类问题，只能手动写一堆代码来控制，最好封装下提供给用户，补充一句：antd正走向世界，如果说React是一个华美绝伦的王冠，我们中国人很希望antd成为那王冠上最璀璨的明珠！

@afc163 afc163 mentioned this issue Jan 6, 2017
Closed
@gushecht
Copy link

@andrewmclagan, do you have a solution that I can borrow?

@hlindley-ccssi
Copy link

hlindley-ccssi commented Feb 8, 2017 •
edited
Loading

I'm also looking for a solution for this. @andrewmclagan @gushecht , did you find anything to make this possible?

@pwax
Copy link

pwax commented Feb 23, 2017

Also looking for 12 hour formatting 👍

@megawac
Copy link
Contributor

megawac commented Feb 23, 2017

Related: react-component/time-picker#27

@afc163
Copy link
Member

afc163 commented Mar 2, 2017

@shaleynikov is working on it.

react-component/time-picker#34

@afc163 afc163 mentioned this issue Mar 2, 2017
Merged
@pwax
Copy link

pwax commented Mar 12, 2017

Since 12 hour mode has been merged, is there an easy way to integrate it to ant? I'd love to contribute but I'm unsure how to incorporate the 12 hour format in the ant TimePicker.

@shaleynikov
Copy link

@pwax I'll try to bring PR on that next couple of days. There is only one new option -- use12Hours, so code should be trivial.

@benjycui benjycui added Accept You are right, we should do that and removed Enhancement labels Mar 13, 2017
@afc163 afc163 mentioned this issue Mar 14, 2017
Closed
afc163 added a commit that referenced this issue Mar 22, 2017
@afc163
TimePicker support 12 hours format, close #4063
2214ac2
@afc163 afc163 mentioned this issue Mar 22, 2017
Merged
benjycui pushed a commit that referenced this issue Mar 22, 2017
@afc163 @benjycui
feat: 12 hours time picker (#5434)
9a0b9ad 
* TimePicker support 12 hours format, close #4063

* Add new demo snapshot
@afc163 afc163 closed this as completed Mar 28, 2017
@lock
Copy link

lock bot commented May 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Accept You are right, we should do that help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@yesmeck @afc163 @andrewmclagan @pwax @gushecht @megawac @benjycui @shaleynikov @hlindley-ccssi @dreamcatcher081210