Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add showZero option to Badge component #4251

Closed
jmatsushita opened this issue Dec 14, 2016 · 7 comments
Closed

Add showZero option to Badge component #4251

jmatsushita opened this issue Dec 14, 2016 · 7 comments
Assignees
@benjycui
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@jmatsushita
Copy link

I would like to be able to show a 0 for my Badge component. Right now it's hidden when equal to 0. I propose to introduce a new boolean prop showZero which would show the badge even when count equals 0.

I'm working on a pull request now, let me know if you'd be interested!
jmatsushita added a commit to iilab/ant-design that referenced this issue Dec 14, 2016
@jmatsushita
Add showZero prop for Badge ant-design#4251
bc9a913
@BANG88 BANG88 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Dec 14, 2016
@kvetoslavnovak
Copy link
Contributor

Good point.

@kvetoslavnovak kvetoslavnovak mentioned this issue Dec 15, 2016
Closed
@kvetoslavnovak
Copy link
Contributor

kvetoslavnovak commented Dec 15, 2016 •
edited
Loading

PR added
Edit: I just discovered we were doing parallel change and PR, so I am taking mine back.

@afc163
Copy link
Member

afc163 commented Jan 7, 2017 •
edited
Loading

@jmatsushita @kvetoslavnovak Can't find any PR coming.

@afc163
Copy link
Member

afc163 commented Jan 17, 2017

ping~

@kvetoslavnovak
Copy link
Contributor

@jmatsushita @afc163 - PR made by jmatsushita did not have test case and was closed #4267

@benjycui
Copy link
Contributor

benjycui commented Feb 6, 2017

@kvetoslavnovak yep, and you should PR to branch feature-2.8 now.

@afc163 afc163 added the Feature label Feb 26, 2017
@benjycui benjycui self-assigned this Feb 28, 2017
benjycui added a commit that referenced this issue Feb 28, 2017
@benjycui
feat: support Badge[showZero], close: #4251
39cddf5
yesmeck pushed a commit that referenced this issue Mar 1, 2017
@benjycui @yesmeck
feat: support Badge[showZero], close: #4251 (#5096)
ef23758
@benjycui benjycui closed this as completed Mar 1, 2017
@lock
Copy link

lock bot commented May 2, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benjycui benjycui

Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jmatsushita @BANG88 @afc163 @benjycui @kvetoslavnovak