Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When clicked outside the table filters drop-down, it also apply the changes #43908

Closed
zeelmodi-simform opened this issue Jul 31, 2023 · 2 comments
Labels
improvement improve some features Inactive

Comments

@zeelmodi-simform
Copy link

zeelmodi-simform commented Jul 31, 2023

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. Click on the filters icon on Name column
  2. Select "Joe"
  3. Click on any area outside the dropdown
  4. Observe the table data

What is expected?

The table filters should be applied when clicked on Okay/Reset button but they are applying with outside clicks as well. I want a way to disable this

What is actually happening?

The table filters are applying with outside clicks as well.

Environment Info
antd 4.24.1
React 18.2.0
System Ubuntu 20.04.6 LTS
Browser Google Chrome 115.0.5790.102
@zeelmodi-simform
Copy link
Author

zeelmodi-simform commented Jul 31, 2023

@afc163 @zombieJ Can you please help here??

@MadCcc MadCcc added improvement improve some features and removed unconfirmed labels Aug 2, 2023
@xsjcTony
Copy link
Contributor

+1. It could be better to provide a boolean prop on the column to configure this.

@MadCcc Sorry for the ping, as I just want to check whether you can receive notification even without being assigned (as I can see you are one of the participants of this issue).
I recently got scolded because of pinging OSS maintainer straight away🤣. If you can in this scenario, I'll not use @ anymore.

I may try to attempt to give PR for this, but depends on my time availability.

Does the official team have any plan for this enhancement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement improve some features Inactive
Projects
None yet
Development

No branches or pull requests

4 participants