Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(table): add filterOnClose prop for Column #47451

Merged
merged 2 commits into from Feb 18, 2024
Merged

feat(table): add filterOnClose prop for Column #47451

merged 2 commits into from Feb 18, 2024

Conversation

xsjcTony
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #43908

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add an option to not trigger the filter when the dropdown menu closes
🇨🇳 Chinese 添加在下拉菜单关闭时不触发筛选的选项

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented Feb 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited

👁 Visual Regression Report for PR #47451 Passed ✅

🎯 Target branch: feature (a149377)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited

Preview is ready

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov Codecov
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85fb745) 100.00% compared to head (0966730) 100.00%.
Report is 163 commits behind head on feature.

Additional details and impacted files 
@@            Coverage Diff            @@
##           feature    #47451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       734    +2     
  Lines        12548     12596   +48     
  Branches      3291      3300    +9     
=========================================
+ Hits         12548     12596   +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 20cd731 into ant-design:feature Feb 18, 2024
63 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。

li-jia-nan
li-jia-nan reviewed Feb 19, 2024
View reviewed changes
components/table/index.en-US.md
@@ -192,6 +192,7 @@ One of the Table `columns` prop for describing the table's columns, Column has t
| filtered | Whether the `dataSource` is filtered | boolean | false | |
| filteredValue | Controlled filtered value, filter icon will highlight | string\[] | - | |
| filterIcon | Customized filter icon | ReactNode \| (filtered: boolean) => ReactNode | - | |
| filterOnClose | Whether to trigger filter when the filter menu closes | boolean | true | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

版本号没写

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

阿巴阿巴🤦‍♀️

li-jia-nan
li-jia-nan reviewed Feb 19, 2024
View reviewed changes
components/table/index.zh-CN.md
@@ -193,6 +193,7 @@ const columns = [
| filtered | 标识数据是否经过过滤，筛选图标会高亮 | boolean | false | |
| filteredValue | 筛选的受控属性，外界可用此控制列的筛选状态，值为已筛选的 value 数组 | string\[] | - | |
| filterIcon | 自定义 filter 图标。 | ReactNode \| (filtered: boolean) => ReactNode | false | |
| filterOnClose | 是否在筛选菜单关闭时触发筛选 | boolean | true | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xrkffgg xrkffgg mentioned this pull request Mar 1, 2024
Merged
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
@xsjcTony
feat(table): add filterOnClose prop for Column (ant-design#47451)
e12b5a8 
* feat(table): add `filterOnClose` prop for `Column`

* docs(table): add `filterOnClose` into `Column`'s API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jia-nan li-jia-nan li-jia-nan left review comments

@afc163 afc163 afc163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xsjcTony @afc163 @li-jia-nan