Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text in dark theme for Menu aren't visible after 2.6.0 update #4440

Closed
pastelsky opened this issue Jan 2, 2017 · 7 comments
Closed

Text in dark theme for Menu aren't visible after 2.6.0 update #4440

pastelsky opened this issue Jan 2, 2017 · 7 comments
Assignees
@afc163
Labels
🐛 Bug Ant Design Team had proved that this is a bug.

Comments

@pastelsky
Copy link
Contributor

After the 2.6.0 update:

screen shot 2017-01-02 at 11 51 10 am
@pastelsky pastelsky changed the title Font colors in dark theme for Menu aren't visible after 2.6.0 update Text in dark theme for Menu aren't visible after 2.6.0 update Jan 2, 2017
@pierre-b
Copy link
Contributor

pierre-b commented Jan 2, 2017 •
edited
Loading

+1 same problem here ;) visible on https://ant.design/docs/spec/layout

@afc163 afc163 assigned ddcat1115 and afc163 and unassigned ddcat1115 Jan 2, 2017
@afc163 afc163 added 🐛 Bug Ant Design Team had proved that this is a bug. Style labels Jan 2, 2017
@afc163 afc163 closed this as completed in d0df37e Jan 2, 2017
@afc163
Copy link
Member

afc163 commented Jan 2, 2017 •
edited
Loading

Keep this open until 2.6.1 patch released.

@afc163 afc163 reopened this Jan 2, 2017
@flyfinec
Copy link

flyfinec commented Jan 4, 2017

2.6.0版本，dark主题下，黑色字体同时又是黑色背景，识别率差了很多，很难一眼看出

@afc163
Copy link
Member

afc163 commented Jan 4, 2017 •
edited
Loading

@flyfinec Don't rush, 2.6.1 will be released at 01-06.

This was referenced Jan 4, 2017
Closed
Closed
afc163 added a commit that referenced this issue Jan 6, 2017
@afc163
Fix Menu[theme=dark] selected and disabled style, #4440
0d38fef
@xuliuzhu1834
Copy link

我用的2.5.3 也是同样的问题

@afc163
Copy link
Member

afc163 commented Jan 6, 2017

^2.5.3 is not 2.5.3.

@benjycui benjycui closed this as completed Jan 6, 2017
@lock
Copy link

lock bot commented May 2, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@afc163 afc163

Labels
🐛 Bug Ant Design Team had proved that this is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@afc163 @pierre-b @flyfinec @benjycui @ddcat1115 @xuliuzhu1834 @pastelsky