Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge component does not display correctly when browser zoom above 100% #4747

Closed
jch254 opened this issue Feb 3, 2017 · 3 comments · Fixed by #4749
Closed

Badge component does not display correctly when browser zoom above 100% #4747

jch254 opened this issue Feb 3, 2017 · 3 comments · Fixed by #4749
Assignees
@afc163
Labels
🐛 Bug Ant Design Team had proved that this is a bug.

Comments

@jch254
Copy link
Contributor

jch254 commented Feb 3, 2017

Environment

  • antd version: 2.6.4
  • OS and its version: macOS Sierra v10.12.3
  • Browser and its version: Google Chrome v55.0.2883.95

What did you do? Please provide steps to re-produce your problem.

Increased browser zoom above 100% and rendered Badge component in ant.design documentation (https://ant.design/components/badge/#components-badge-demo-no-wrapper).

What did you expect?

Badge component should display correctly at all zoom levels - this is important for accessibility.

What happened?

Badge component is not displayed correctly when browser zoom above 100%.

badge

Re-producible online demo

Visit https://ant.design/components/badge/#components-badge-demo-no-wrapper and increase browser zoom above 100%.

I found this related issue #4290 but could not figure out if it was solved (Google Translate struggles with Chinese).
@afc163 afc163 self-assigned this Feb 3, 2017
@afc163 afc163 added 🐛 Bug Ant Design Team had proved that this is a bug. Style labels Feb 3, 2017
@afc163
Copy link
Member

afc163 commented Feb 3, 2017

I will fix this now.

afc163 added a commit that referenced this issue Feb 3, 2017
@afc163
Fix misplace Badge when browser zoom above 100%
115f8c1 
close #4747 #4290 #4176
@afc163 afc163 mentioned this issue Feb 3, 2017
Merged
@jch254
Copy link
Contributor Author

jch254 commented Feb 3, 2017

@afc163 you are a champion, thanks!

afc163 added a commit that referenced this issue Feb 3, 2017
@afc163
Fix misplace Badge when browser zoom above 100% (#4749)
f786f60 
close #4747 #4290 #4176
@lock
Copy link

lock bot commented May 2, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@afc163 afc163

Labels
🐛 Bug Ant Design Team had proved that this is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix misplace Badge when browser zoom above 100% ant-design/ant-design
2 participants
@afc163 @jch254