Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

希望Select multiple能支持clear #4843

Closed
qiaoyixuan opened this issue Feb 13, 2017 · 10 comments
Closed

希望Select multiple能支持clear #4843

qiaoyixuan opened this issue Feb 13, 2017 · 10 comments
Assignees
@benjycui

Comments

@qiaoyixuan
Copy link
Contributor

qiaoyixuan commented Feb 13, 2017 •
edited
Loading

RT
<Select multiple allowClear />
@RaoHai
Copy link
Contributor

RaoHai commented Feb 14, 2017

https://github.com/react-component/select/blob/master/src/Select.jsx#L938

是做了特殊判断的不支持。@yiminghe 这里是有什么设计么？

@yiminghe
Copy link
Contributor

设计，交互 没有

@yesmeck yesmeck mentioned this issue Feb 14, 2017
Closed
@benjycui
Copy link
Contributor

ping 了交互，他们讨论先吧。

@benjycui
Copy link
Contributor

benjycui commented Feb 28, 2017 •
edited
Loading

image

@benjycui
Copy link
Contributor

设计稿可以了。

@afc163
Copy link
Member

afc163 commented Feb 28, 2017

有点麻烦，有可能互相覆盖。

@benjycui
Copy link
Contributor

那只能让设计再更新下设计稿了。。

@benjycui
Copy link
Contributor

benjycui commented Mar 1, 2017

设计稿已更新 #4843 (comment)

@benjycui benjycui assigned benjycui and unassigned RaoHai and ddcat1115 Mar 22, 2017
@benjycui
Copy link
Contributor

业务需要，这周完成吧。。

@benjycui benjycui mentioned this issue Mar 24, 2017
Merged
@benjycui benjycui mentioned this issue Mar 24, 2017
Merged
benjycui added a commit that referenced this issue Mar 24, 2017
@benjycui
fix: Select[multiple|tags] should support allowClear, close: #4843
e381401
benjycui added a commit that referenced this issue Mar 27, 2017
@benjycui
fix: Select[multiple|tags] should support allowClear, close: #4843
6f10872
benjycui added a commit that referenced this issue Mar 27, 2017
@benjycui
fix: Select[multiple|tags] should support allowClear, close: #4843
d22e4b4
benjycui added a commit that referenced this issue Mar 27, 2017
@benjycui
fix: Select[multiple|tags] should support allowClear, close: #4843
e2b44c2
afc163 pushed a commit that referenced this issue Mar 27, 2017
@benjycui @afc163
fix: Select[multiple|tags] should support allowClear, close: #4843 (#…
cb555fc 
…5478)
@lock
Copy link

lock bot commented May 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benjycui benjycui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@yiminghe @afc163 @RaoHai @benjycui @ddcat1115 @qiaoyixuan