Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It'd be better if Tabs has an option to disable the switch-animation of the short horizontal line. #5089

Closed
xieguanglei opened this issue Feb 28, 2017 · 12 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@xieguanglei
Copy link
Contributor

It'd be better if Tabs has an option to disable the switch-animation of the short horizontal line.

@benjycui
Copy link
Contributor

Do you mean inkBar?

image

@xieguanglei
Copy link
Contributor Author

xieguanglei commented Feb 28, 2017

Yes, that's right. When I switch tab from one to another, the inkBar just 'slides' along. Sometimes I just want the inkBar to suddenly change its position.

@benjycui
Copy link
Contributor

Maybe we can make Tabs[animated] to control InkBar animation and TabPane animation at the same time?

@xieguanglei
Copy link
Contributor Author

xieguanglei commented Feb 28, 2017

It may depends on ant-design : should we always enable/disable the two animation at the same time?

To me, either a single prop or two seperated props is ok.

@benjycui
Copy link
Contributor

benjycui commented Mar 1, 2017

Tabs[animate] could be boolean, which means that enable or disable animation for InkBar and TabPane animation at the same time.

And it could be Object { inkBar: boolean, tabPane: boolean }, which will control InkBar and TabPane respectively.

@benjycui benjycui added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. and removed 🗣 Discussion labels Mar 1, 2017
@benjycui
Copy link
Contributor

benjycui commented Mar 1, 2017

@xieguanglei you can try.

@xieguanglei
Copy link
Contributor Author

working on it.

@benjycui
Copy link
Contributor

ping~ @xieguanglei

@xieguanglei
Copy link
Contributor Author

sorry,I went to some trouble setting up the typescript dev-enviroment and I was too busy to figure out how to make it right.

so could I have an extra week on this issue? @benjycui

@benjycui
Copy link
Contributor

Take your time. I just ping you, in case that you had forgot..

@xieguanglei
Copy link
Contributor Author

done @benjycui

xieguanglei pushed a commit to xieguanglei/ant-design that referenced this issue Mar 23, 2017
xieguanglei pushed a commit to xieguanglei/ant-design that referenced this issue Mar 23, 2017
benjycui pushed a commit that referenced this issue Mar 24, 2017
@lock
Copy link

lock bot commented May 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

2 participants