Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Custom Selection Dropdown in Table to be toggled off #5246

Closed
simondiep opened this issue Mar 9, 2017 · 11 comments · Fixed by #5409
Closed

Allow Custom Selection Dropdown in Table to be toggled off #5246

simondiep opened this issue Mar 9, 2017 · 11 comments · Fixed by #5409

Comments

@simondiep
Copy link

simondiep commented Mar 9, 2017

Environment(required)

  • antd version: 2.8.0
  • OS and its version: OSX El Capitan
  • Browser and its version: Chrome v56

What did you do? Please provide steps to re-produce your problem.

I updated my web app from Ant 2.7.4 to 2.8.0.

What do you expected?

I expected no visual changes. Since this new feature was added, it would be nice to have it disabled by default and opt-in.

What happen?

New Feature introduced in 2.8.0 - #4962
I noticed an additional dropdown icon that shows up on my Ant Table next to a checkbox. When expanded, the dropdown shows two items, both in Chinese.

Re-producible online demo

https://ant.design/components/table/

@benjycui
Copy link
Contributor

When expanded, the dropdown shows two items, both in Chinese.

Try LocaleProvider.

@benjycui
Copy link
Contributor

And I had pointed out this #4962 (comment)

cc @afc163 @infeng

@afc163
Copy link
Member

afc163 commented Mar 15, 2017

How about selections could be true for default select dropdown.

  • not set: no select dropdown
  • selections={true}: have default select dropdown
  • selections={[ ... ]}: have default select dropdown and more options

@infeng
Copy link
Contributor

infeng commented Mar 15, 2017

I think selections={true} is not necessary, it can use selections={[]} replace

@afc163
Copy link
Member

afc163 commented Mar 15, 2017

selections={[]} is hard to understand.

We can follow rowSelection case, which is { ... } and also could be true.

@infeng
Copy link
Contributor

infeng commented Mar 15, 2017

you are right, let me send a PR.

@hungtuchen
Copy link

Can you consider the case with no default options but custom one?
I have a use case when using select all, I want to select all the rows across different pages, which current default option is just select rows in current page.
@afc163 @infeng

@benjycui
Copy link
Contributor

I have a use case when using select all, I want to select all the rows across different pages, which current default option is just select rows in current page.

Just listen to onSelectAll and select all the rows across different pages.

@hungtuchen
Copy link

Thanks @benjycui, still looking forward an option we can't choose not to use dropdown

@afc163
Copy link
Member

afc163 commented Mar 21, 2017

#5246 (comment)

@lock
Copy link

lock bot commented May 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants