Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message getContainer doesn't work #5380

Closed
lcoder opened this issue Mar 18, 2017 · 5 comments · Fixed by #5381
Closed

message getContainer doesn't work #5380

lcoder opened this issue Mar 18, 2017 · 5 comments · Fixed by #5381

Comments

@lcoder
Copy link

lcoder commented Mar 18, 2017

message.config( {
    getContainer(){
        console.log('1')   // this should be console.log 1 , but doesn't
        return document.body ;
    }
} )

I checkd the code: config options: ConfigOptions find that getContainer never pass into the message module. anyone can fixed it?

afc163 added a commit that referenced this issue Mar 18, 2017
afc163 added a commit that referenced this issue Mar 18, 2017
* Fix message getContainer, close #5380

* Add test for message getContainer

* Add test for message config top

* more test for message destroy
@NE-SmallTown
Copy link
Contributor

NE-SmallTown commented Mar 19, 2017

Due to here,maybe the doc needs to update too?

So from

message.config({
  top: 100,
  duration: 2,
})

to

message.config({
  top: 100,
  duration: 2,
  getContainer: document.getElementById('myMessageContainer')
})

And from

This components provides 4 static methods

to

This components provides 6 static methods

or

This components provides above static methods

@afc163
Copy link
Member

afc163 commented Mar 19, 2017

@NE-SmallTown you can PR to improve the documentation.

@NE-SmallTown
Copy link
Contributor

@afc163 Ye,but to be honest,at most situations, I am not sure what I do is 100% right,so I think discuss in the issue at first would be better.PRs are more serious and holy than issues for repos.

On the other hand,maybe I will go outside or have something busy to do,so if anyone see this,they can pr too 😄

@afc163
Copy link
Member

afc163 commented Mar 19, 2017

140f3fb

@lock
Copy link

lock bot commented May 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants