Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Popover and SelectionCheckboxAll items behaviour #5407

Closed
plandem opened this issue Mar 20, 2017 · 4 comments
Closed

[Table] Popover and SelectionCheckboxAll items behaviour #5407

plandem opened this issue Mar 20, 2017 · 4 comments

Comments

@plandem
Copy link
Contributor

plandem commented Mar 20, 2017

In case of table inside of Popover any click on 'selectAll' will close Popover.

@plandem plandem changed the title [Table] prevent default for SelectionCheckboxAll items [Table] Popover and SelectionCheckboxAll items behaviour Mar 20, 2017
@hansnow
Copy link
Contributor

hansnow commented Mar 21, 2017

There is no event argument passed to rowSelection's onSelectAll or onSelectInvert, so controlling Popover.visible manually seems to be the only choice for the moment.

@afc163
Copy link
Member

afc163 commented Mar 21, 2017

@plandem
Could you provide a re-producible demo to help us, by forking and editing this codepen: http://codepen.io/benjycui/pen/KgPZrE?editors=001

(A good and minimum codpen will save a lot of time 😃)

@plandem
Copy link
Contributor Author

plandem commented Mar 21, 2017

@afc163

sure. here is it:
http://codepen.io/anon/pen/mWXYVx?editors=001

P.S.: at demo you can see an issue with onHover also. So we have 2 issue with selectAll - onHover at menuItem and onClick on menuItem.

P.P.S.: I suppose its connected with case "Popover inside of Popover".

@lock
Copy link

lock bot commented May 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants