Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs break change in 2.9.2 with padding added #5877

Closed
jaredleechn opened this issue Apr 24, 2017 · 1 comment
Closed

Tabs break change in 2.9.2 with padding added #5877

jaredleechn opened this issue Apr 24, 2017 · 1 comment
Labels
🐛 Bug Ant Design Team had proved that this is a bug.

Comments

@jaredleechn
Copy link
Contributor

jaredleechn commented Apr 24, 2017 •
edited
Loading

Version

2.9.2

Environment

does not matter

Reproduction link

https://ant.design/components/tabs-cn/#components-tabs-demo-position

Steps to reproduce

choose postion into left, and inspect the tabs, you will find div.ant-tabs-nav-container with a padding: 32px property. It was imported in v2.9.2 as a break change.

What is expected?

no extra padding, no break change.

What is actually happening?

padding added for div.ant-tabs-nav-container

Roughly checking the pr, I think the author maybe want to add padding to div.ant-tabs-nav-container.ant-tabs-nav-container-scrolling indeed

@dicklwm #5784
@jaredleechn jaredleechn added the 🐛 Bug Ant Design Team had proved that this is a bug. label Apr 24, 2017
dicklwm added a commit to dicklwm/ant-design that referenced this issue Apr 25, 2017
@dicklwm
fix the break change ant-design#5877
4dda94c 
Signed-off-by: Min <dicklwm@163.com>
@dicklwm dicklwm mentioned this issue Apr 25, 2017
Merged
benjycui pushed a commit that referenced this issue Apr 25, 2017
@dicklwm @benjycui
fix: the breaking change #5877 (#5886)
6cd05d8 
* Fix the bug
When tabPostition = 'left' | | 'right, slideButton should be on the up and down, but the actual in left and right

Signed-off-by: Min <dicklwm@163.com>

* fix the break change #5877

Signed-off-by: Min <dicklwm@163.com>
@lock
Copy link

lock bot commented May 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐛 Bug Ant Design Team had proved that this is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjycui @jaredleechn