Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加配置项,允许鼠标经过时停止duration计时,鼠标移出后恢复计时 #7513

Closed
HeZiGang opened this issue Sep 8, 2017 · 14 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@HeZiGang
Copy link

HeZiGang commented Sep 8, 2017

What problem does this feature solve?

如果Notification比较长,用户需要仔细查看其内容,就可以在它自动关闭以前将鼠标移动到它上面。使其不会自动关闭。

What does the proposed API look like?

增加一个bool值的config节点, 允许用户选择是否启用这个功能。

@ant-design-bot
Copy link
Contributor

It will be better to write your issue/comment in English, so more people can understand you.
And this means that more people can help you or benefit from your issue/comment.
See: #4897

@benjycui
Copy link
Contributor

benjycui commented Sep 8, 2017

有道理,可以 PR 到 rc-notification?

@afc163
Copy link
Member

afc163 commented Sep 8, 2017

👍 It is useful.

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Sep 8, 2017
@HeZiGang
Copy link
Author

HeZiGang commented Sep 8, 2017

我提交到那边去了, 希望他能读懂我蹩脚的英文
react-component/notification#25

@afc163
Copy link
Member

afc163 commented Sep 8, 2017

你可以直接 PR 过去,那边也是我们在维护。

@HeZiGang
Copy link
Author

HeZiGang commented Sep 8, 2017

这还是我第一次在github上面提PR,不知道怎么直接PR过去。另外,我下载了rc-notification的代码,增加了一个名为freezeWhenMouseOver的属性,实现了这个功能,但是不知道怎么把代码贡献给你们。-_-||,加上simple.js总共改了3个文件,贴代码好像也不对。

@afc163
Copy link
Member

afc163 commented Sep 8, 2017

学习一下:https://www.zhihu.com/question/21682976

@benjycui
Copy link
Contributor

benjycui commented Sep 8, 2017

增加了一个名为freezeWhenMouseOver的属性

其实我觉得可以不加属性,直接默认行为即可。

@HeZiGang
Copy link
Author

HeZiGang commented Sep 8, 2017

@afc163 谢谢,学习一下,晚上回家试试,公司不能用Git客户端
@benjycui 好的

@HeZiGang
Copy link
Author

@afc163 之前忘了修改邮箱了,所以那个PR我是匿名提交的,现在我增加了测试用例,把code coverage增加到了100,是不是需要关闭之前那个PR,然后PR过去。

@afc163
Copy link
Member

afc163 commented Sep 10, 2017

不用,直接在那个分支上继续 push 就好。

@afc163 afc163 closed this as completed Sep 15, 2017
@afc163
Copy link
Member

afc163 commented Sep 15, 2017

Thx @HeZiGang, just reinstall node_modules.

@HeZiGang
Copy link
Author

It's OK, 如果需要帮忙fix bug或者加什么功能什么的,也可以@我,我晚上和周末都满闲的,我也想做点力所能及的贡献,不能老是白用大家贡献的代码。😁

@afc163
Copy link
Member

afc163 commented Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

4 participants