New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
增加配置项,允许鼠标经过时停止duration计时,鼠标移出后恢复计时 #7513
Comments
It will be better to write your issue/comment in English, so more people can understand you. |
有道理,可以 PR 到 rc-notification? |
👍 It is useful. |
我提交到那边去了, 希望他能读懂我蹩脚的英文 |
你可以直接 PR 过去,那边也是我们在维护。 |
这还是我第一次在github上面提PR,不知道怎么直接PR过去。另外,我下载了rc-notification的代码,增加了一个名为freezeWhenMouseOver的属性,实现了这个功能,但是不知道怎么把代码贡献给你们。-_-||,加上simple.js总共改了3个文件,贴代码好像也不对。 |
其实我觉得可以不加属性,直接默认行为即可。 |
@afc163 之前忘了修改邮箱了,所以那个PR我是匿名提交的,现在我增加了测试用例,把code coverage增加到了100,是不是需要关闭之前那个PR,然后PR过去。 |
不用,直接在那个分支上继续 push 就好。 |
Thx @HeZiGang, just reinstall node_modules. |
It's OK, 如果需要帮忙fix bug或者加什么功能什么的,也可以@我,我晚上和周末都满闲的,我也想做点力所能及的贡献,不能老是白用大家贡献的代码。😁 |
There is a lot of issues need to do: https://github.com/ant-design/ant-design/issues?q=is%3Aopen+is%3Aissue+label%3A%22PR+welcome%22 |
What problem does this feature solve?
如果Notification比较长,用户需要仔细查看其内容,就可以在它自动关闭以前将鼠标移动到它上面。使其不会自动关闭。
What does the proposed API look like?
增加一个bool值的config节点, 允许用户选择是否启用这个功能。
The text was updated successfully, but these errors were encountered: