Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new behavior to notification #26

Merged
merged 6 commits into from Sep 15, 2017
Merged

Conversation

HeZiGang
Copy link
Contributor

@HeZiGang HeZiGang commented Sep 8, 2017

  1. Add new behaver notification layer, freeze the layer when mouseover.
  2. Fix lint issues.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.039% when pulling fa7697d on HeZiGang:master into 7568c4e on react-component:master.

@afc163
Copy link
Member

afc163 commented Sep 8, 2017

You can try add test case for this feature.

@afc163
Copy link
Member

afc163 commented Sep 8, 2017

image

@afc163
Copy link
Member

afc163 commented Sep 8, 2017

And add a option for it, like we discussed in ant-design/ant-design#7513

@HeZiGang
Copy link
Contributor Author

HeZiGang commented Sep 9, 2017

@afc163 , I saw that @benjycui said don't need add a new option for it and make the new feature as the default behave. so, i remove the additional option from source code.

anyway, I can try to add some test case for it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.039% when pulling 2fdab2e on HeZiGang:master into 7568c4e on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.039% when pulling 2943094 on HeZiGang:master into 7568c4e on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.039% when pulling aec1233 on HeZiGang:master into 7568c4e on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.0%) to 100.0% when pulling efd62c4 on HeZiGang:master into 7568c4e on react-component:master.

@benjycui
Copy link
Member

And add a option for it, like we discussed in ant-design/ant-design#7513

I think it is OK to be the default behavior of rc-notification.

@afc163
Copy link
Member

afc163 commented Sep 11, 2017

Could be a little wired for message: http://ant.design/components/message/

@benjycui
Copy link
Member

But if I put cursor on a message/notification, this means that I am reading the message, and it had better not disappear..

@afc163 afc163 merged commit 96bdaca into react-component:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants